Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Side by Side Diff: src/hydrogen-instructions.cc

Issue 140943002: Fix logic error in assert in IsUndeclaredGlobal() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ports and addressed comments. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/ic-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3333 matching lines...) Expand 10 before | Expand all | Expand 10 after
3344 3344
3345 3345
3346 void HStoreGlobalCell::PrintDataTo(StringStream* stream) { 3346 void HStoreGlobalCell::PrintDataTo(StringStream* stream) {
3347 stream->Add("[%p] = ", *cell().handle()); 3347 stream->Add("[%p] = ", *cell().handle());
3348 value()->PrintNameTo(stream); 3348 value()->PrintNameTo(stream);
3349 if (!details_.IsDontDelete()) stream->Add(" (deleteable)"); 3349 if (!details_.IsDontDelete()) stream->Add(" (deleteable)");
3350 if (details_.IsReadOnly()) stream->Add(" (read-only)"); 3350 if (details_.IsReadOnly()) stream->Add(" (read-only)");
3351 } 3351 }
3352 3352
3353 3353
3354 void HStoreGlobalGeneric::PrintDataTo(StringStream* stream) {
3355 stream->Add("%o = ", *name());
3356 value()->PrintNameTo(stream);
3357 }
3358
3359
3360 void HLoadContextSlot::PrintDataTo(StringStream* stream) { 3354 void HLoadContextSlot::PrintDataTo(StringStream* stream) {
3361 value()->PrintNameTo(stream); 3355 value()->PrintNameTo(stream);
3362 stream->Add("[%d]", slot_index()); 3356 stream->Add("[%d]", slot_index());
3363 } 3357 }
3364 3358
3365 3359
3366 void HStoreContextSlot::PrintDataTo(StringStream* stream) { 3360 void HStoreContextSlot::PrintDataTo(StringStream* stream) {
3367 context()->PrintNameTo(stream); 3361 context()->PrintNameTo(stream);
3368 stream->Add("[%d] = ", slot_index()); 3362 stream->Add("[%d] = ", slot_index());
3369 value()->PrintNameTo(stream); 3363 value()->PrintNameTo(stream);
(...skipping 1081 matching lines...) Expand 10 before | Expand all | Expand 10 after
4451 break; 4445 break;
4452 case kExternalMemory: 4446 case kExternalMemory:
4453 stream->Add("[external-memory]"); 4447 stream->Add("[external-memory]");
4454 break; 4448 break;
4455 } 4449 }
4456 4450
4457 stream->Add("@%d", offset()); 4451 stream->Add("@%d", offset());
4458 } 4452 }
4459 4453
4460 } } // namespace v8::internal 4454 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/ia32/ic-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698