Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: src/disassembler.cc

Issue 140943002: Fix logic error in assert in IsUndeclaredGlobal() (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ports and addressed comments. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/code-stubs.h ('k') | src/full-codegen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 ref_encoder.NameOfAddress(relocinfo.target_reference()); 230 ref_encoder.NameOfAddress(relocinfo.target_reference());
231 out.AddFormatted(" ;; external reference (%s)", reference_name); 231 out.AddFormatted(" ;; external reference (%s)", reference_name);
232 } else if (RelocInfo::IsCodeTarget(rmode)) { 232 } else if (RelocInfo::IsCodeTarget(rmode)) {
233 out.AddFormatted(" ;; code:"); 233 out.AddFormatted(" ;; code:");
234 if (rmode == RelocInfo::CONSTRUCT_CALL) { 234 if (rmode == RelocInfo::CONSTRUCT_CALL) {
235 out.AddFormatted(" constructor,"); 235 out.AddFormatted(" constructor,");
236 } 236 }
237 Code* code = Code::GetCodeFromTargetAddress(relocinfo.target_address()); 237 Code* code = Code::GetCodeFromTargetAddress(relocinfo.target_address());
238 Code::Kind kind = code->kind(); 238 Code::Kind kind = code->kind();
239 if (code->is_inline_cache_stub()) { 239 if (code->is_inline_cache_stub()) {
240 if (code->IsContextual()) { 240 if (kind == Code::LOAD_IC &&
241 LoadIC::GetContextualMode(code->extra_ic_state()) == CONTEXTUAL) {
241 out.AddFormatted(" contextual,"); 242 out.AddFormatted(" contextual,");
242 } 243 }
243 InlineCacheState ic_state = code->ic_state(); 244 InlineCacheState ic_state = code->ic_state();
244 out.AddFormatted(" %s, %s", Code::Kind2String(kind), 245 out.AddFormatted(" %s, %s", Code::Kind2String(kind),
245 Code::ICState2String(ic_state)); 246 Code::ICState2String(ic_state));
246 if (ic_state == MONOMORPHIC) { 247 if (ic_state == MONOMORPHIC) {
247 Code::StubType type = code->type(); 248 Code::StubType type = code->type();
248 out.AddFormatted(", %s", Code::StubType2String(type)); 249 out.AddFormatted(", %s", Code::StubType2String(type));
249 } 250 }
250 if (kind == Code::CALL_IC || kind == Code::KEYED_CALL_IC) { 251 if (kind == Code::CALL_IC || kind == Code::KEYED_CALL_IC) {
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 int Disassembler::Decode(Isolate* isolate, FILE* f, byte* begin, byte* end) { 361 int Disassembler::Decode(Isolate* isolate, FILE* f, byte* begin, byte* end) {
361 return 0; 362 return 0;
362 } 363 }
363 364
364 365
365 void Disassembler::Decode(FILE* f, Code* code) {} 366 void Disassembler::Decode(FILE* f, Code* code) {}
366 367
367 #endif // ENABLE_DISASSEMBLER 368 #endif // ENABLE_DISASSEMBLER
368 369
369 } } // namespace v8::internal 370 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/code-stubs.h ('k') | src/full-codegen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698