Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1409373011: Dedup SkPaths by gen-ID when going to .skp (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Dedup SkPaths by gen-ID when going to .skp We're all set up to serialize and deserialze paths by an integer ID, but we're just not deduping any paths (every path gets a new ID). This turns on deduping. This should mean the number of paths in a deserialized SkPicture are the same as when it was recorded. No diffs: https://gold.skia.org/search2?issue=1409373011&unt=true&query=source_type%3Dgm&master=false BUG=skia:4527 Committed: https://skia.googlesource.com/skia/+/c2e2977014c4581aed5da435fc2b7eba38e777b6

Patch Set 1 #

Patch Set 2 : not reserved #

Total comments: 1

Patch Set 3 : ok, no 0 is reserved #

Patch Set 4 : fix #

Patch Set 5 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M src/core/SkPictureData.cpp View 1 2 3 4 1 chunk +7 lines, -1 line 0 comments Download
M src/core/SkPictureRecord.h View 2 chunks +6 lines, -1 line 0 comments Download
M src/core/SkPictureRecord.cpp View 1 2 4 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 25 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409373011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409373011/1
5 years, 1 month ago (2015-10-28 20:01:23 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-28 20:12:23 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409373011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409373011/20001
5 years, 1 month ago (2015-10-29 14:13:36 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/3896)
5 years, 1 month ago (2015-10-29 14:15:18 UTC) #9
mtklein
https://codereview.chromium.org/1409373011/diff/20001/src/core/SkPictureData.cpp File src/core/SkPictureData.cpp (right): https://codereview.chromium.org/1409373011/diff/20001/src/core/SkPictureData.cpp#newcode50 src/core/SkPictureData.cpp:50: fPaths.reset(record.fPaths.count() + 1); // 0 is reserved. Oops, note ...
5 years, 1 month ago (2015-10-29 14:15:29 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409373011/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409373011/40001
5 years, 1 month ago (2015-10-29 14:48:53 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-29 14:59:22 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409373011/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409373011/80001
5 years, 1 month ago (2015-10-29 21:06:35 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-29 21:17:06 UTC) #18
mtklein_C
5 years, 1 month ago (2015-10-29 21:27:51 UTC) #21
robertphillips
lgtm
5 years, 1 month ago (2015-10-30 11:59:36 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409373011/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409373011/80001
5 years, 1 month ago (2015-10-30 12:24:16 UTC) #24
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 12:25:01 UTC) #25
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/c2e2977014c4581aed5da435fc2b7eba38e777b6

Powered by Google App Engine
This is Rietveld 408576698