[heap] Add concurrency-safe refilling to compaction spaces

[heap] Add concurrency-safe refilling to compaction spaces

BUG=chromium:524425
LOG=N

Committed: https://crrev.com/d6235fc478aefcb5e28b432556bdc35d7dfb7a48
Cr-Commit-Position: refs/heads/master@{#31508}

[Michael Lippautz, 2015-10-21 12:17:08]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-21 12:17:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409363003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409363003/1

[commit-bot: I haz the power, 2015-10-21 12:46:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-21 12:46:46]

Dry run: This issue passed the CQ dry run.

[Michael Lippautz, 2015-10-21 12:55:14]

Description was changed from

==========
[heap] Add concurrency safe refilling to compaction spaces

BUG=
==========

to

==========
[heap] Add concurrency-safe refilling to compaction spaces

BUG=chromium:524425
LOG=N
==========

[Michael Lippautz, 2015-10-21 12:56:57]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Hannes Payer (out of office), 2015-10-22 11:05:14]

https://codereview.chromium.org/1409363003/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1409363003/diff/1/src/heap/mark-compact.cc#ne...
src/heap/mark-compact.cc:551: if (!heap()->concurrent_sweeping_enabled() ||
!IsSweepingCompleted()) {
Let's factor this condition out into a separate function, since it is used
somewhere else as well.

https://codereview.chromium.org/1409363003/diff/1/src/heap/spaces.cc
File src/heap/spaces.cc (right):

https://codereview.chromium.org/1409363003/diff/1/src/heap/spaces.cc#newcode2716
src/heap/spaces.cc:2716: HeapObject* PagedSpace::SweepAndRetry(int
size_in_bytes) {
Let's call it SweepAndRetryAllocation.

https://codereview.chromium.org/1409363003/diff/1/src/heap/spaces.cc#newcode2730
src/heap/spaces.cc:2730: HeapObject* CompactionSpace::SweepAndRetry(int
size_in_bytes) {
Same same.

[Michael Lippautz, 2015-10-22 12:50:38]

PTAL ~=[,,_,,]:3

https://codereview.chromium.org/1409363003/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1409363003/diff/1/src/heap/mark-compact.cc#ne...
src/heap/mark-compact.cc:551: if (!heap()->concurrent_sweeping_enabled() ||
!IsSweepingCompleted()) {
On 2015/10/22 11:05:13, Hannes Payer wrote:
> Let's factor this condition out into a separate function, since it is used
> somewhere else as well.

As discussed offline, the condition we want is actually different.

https://codereview.chromium.org/1409363003/diff/1/src/heap/spaces.cc
File src/heap/spaces.cc (right):

https://codereview.chromium.org/1409363003/diff/1/src/heap/spaces.cc#newcode2716
src/heap/spaces.cc:2716: HeapObject* PagedSpace::SweepAndRetry(int
size_in_bytes) {
On 2015/10/22 11:05:13, Hannes Payer wrote:
> Let's call it SweepAndRetryAllocation.

Done.

https://codereview.chromium.org/1409363003/diff/1/src/heap/spaces.cc#newcode2730
src/heap/spaces.cc:2730: HeapObject* CompactionSpace::SweepAndRetry(int
size_in_bytes) {
On 2015/10/22 11:05:13, Hannes Payer wrote:
> Same same.

Done done.

[Michael Lippautz, 2015-10-22 13:02:03]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-22 13:02:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409363003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409363003/20001

[commit-bot: I haz the power, 2015-10-22 13:39:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 13:39:53]

Dry run: Try jobs failed on following builders:
  v8_win64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/9901)

[Michael Lippautz, 2015-10-22 13:45:00]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-22 13:45:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409363003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409363003/40001

[commit-bot: I haz the power, 2015-10-22 14:28:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 14:28:49]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2015-10-23 10:14:04]

lgtm

[Michael Lippautz, 2015-10-23 10:26:08]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2015-10-23 10:26:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409363003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409363003/40001

[commit-bot: I haz the power, 2015-10-23 10:27:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-23 10:27:52]

Patchset 3 (id:??) landed as
https://crrev.com/d6235fc478aefcb5e28b432556bdc35d7dfb7a48
Cr-Commit-Position: refs/heads/master@{#31508}