Issue 1409333002: DAS specification changes - spelling and ElementKind.FILE addition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1409333002: DAS specification changes - spelling and ElementKind.FILE addition. (Closed)

Created:
5 years, 2 months ago by scheglov

Modified:
5 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

DAS specification changes - spelling and ElementKind.FILE addition. ElementKind.FILE will be used in search.findElementReferences 1. In the 'element' field of responce when a URI is at the given offset. 2. In the only element of the 'path' field of SearchResult(s) for URI references to a URI or a library identifier. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c0d68a5437e9a35aed549e2c4021bcd5b4abef0d

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -35 lines)			Patch
M	pkg/analysis_server/doc/api.html	View	6 chunks	+7 lines, -7 lines	0 comments	Download
M	pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart	View	8 chunks	+13 lines, -8 lines	0 comments	Download
M	pkg/analysis_server/test/integration/integration_test_methods.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/integration/protocol_matchers.dart	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/generated/java/AnalysisServer.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/tool/spec/generated/java/types/AnalysisOptions.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/generated/java/types/ElementKind.java	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/generated/java/types/HoverInformation.java	View	2 chunks	+8 lines, -8 lines	0 comments	Download
M	pkg/analysis_server/tool/spec/generated/java/types/RequestErrorCode.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/tool/spec/spec_input.html	View	7 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

5 years, 2 months ago (2015-10-17 17:03:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c0d68a5437e9a35aed549e2c4021bcd5b4abef0d (presubmit successful).

Expand Messages | Collapse Messages