Issue 140933004: Break HarfBuzz run creation into separate function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140933004: Break HarfBuzz run creation into separate function (Closed)

Created:
6 years, 11 months ago by eae

Modified:
6 years, 11 months ago

Reviewers:
dglazkov

CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Break HarfBuzz run creation into separate function Break out creation of HarfBuzzRuns out of the collectHarfBuzzRuns method as a part of the effort to clean up the logic to allow proper handling of script_common. BUG=311372 R=dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165253

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
	M	Source/platform/fonts/harfbuzz/HarfBuzzShaper.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp	View		2 chunks	+12 lines, -3 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/140933004/1

6 years, 11 months ago (2014-01-16 20:25:26 UTC) #3

Message was sent while issue was closed.

Change committed as 165253