xfa/src/fwl/src/core/fwl_formimp.cpp - Issue 1409323003: XFA: Remove cond ? TRUE : FALSE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fwl/src/core/fwl_formimp.cpp

Issue 1409323003: XFA: Remove cond ? TRUE : FALSE. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fwl/src/core/fwl_formimp.cpp

diff --git a/xfa/src/fwl/src/core/fwl_formimp.cpp b/xfa/src/fwl/src/core/fwl_formimp.cpp

index 85139ca1a1c834d7b204747bf7ac049fad1939e9..2facbf37578832440e1b58d848e8d3635e32569c 100644

--- a/xfa/src/fwl/src/core/fwl_formimp.cpp

+++ b/xfa/src/fwl/src/core/fwl_formimp.cpp

@@ -885,7 +885,7 @@ void CFWL_FormImp::SetThemeData() {

}

FX_BOOL CFWL_FormImp::HasIcon() {

IFWL_FormDP* pData = (IFWL_FormDP*)m_pProperties->m_pDataProvider;

- return pData->GetIcon(m_pInterface, FALSE) ? TRUE : FALSE;

+ return !!pData->GetIcon(m_pInterface, FALSE);

Tom Sepez 2015/10/19 20:16:10 what's the return type on this? Is it already boo

Lei Zhang 2015/10/20 00:41:43 It's a pointer. xfa/include/fwl/core/fwl_form.h li

Tom Sepez 2015/10/20 16:33:15 Acknowledged.

}

void CFWL_FormImp::UpdateIcon() {

CFWL_WidgetMgr* pWidgetMgr = (CFWL_WidgetMgr*)FWL_GetWidgetMgr();