Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1378)

Unified Diff: xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp

Issue 1409323003: XFA: Remove cond ? TRUE : FALSE. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp
diff --git a/xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp b/xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp
index 4460a8d0e1a8f2c9d58b50beba0a227d8c46a5ae..baf150f2f4f2b056ca0eaeae1631fbee746a6a48 100644
--- a/xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp
+++ b/xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp
@@ -869,13 +869,13 @@ FX_BOOL CFWL_ComboBoxImp::EditPaste(const CFX_WideString& wsPaste) {
return m_pEdit->Paste(wsPaste);
}
FX_BOOL CFWL_ComboBoxImp::EditSelectAll() {
- return (m_pEdit->AddSelRange(0) == FWL_ERR_Succeeded) ? TRUE : FALSE;
+ return !!(m_pEdit->AddSelRange(0) == FWL_ERR_Succeeded);
Tom Sepez 2015/10/19 20:16:10 These three are already booleans, no need for !!,
Lei Zhang 2015/10/20 00:41:43 I think this was right before lunch time, so hunge
}
FX_BOOL CFWL_ComboBoxImp::EditDelete() {
- return (m_pEdit->ClearText() == FWL_ERR_Succeeded) ? TRUE : FALSE;
+ return !!(m_pEdit->ClearText() == FWL_ERR_Succeeded);
}
FX_BOOL CFWL_ComboBoxImp::EditDeSelect() {
- return (m_pEdit->ClearSelections() == FWL_ERR_Succeeded) ? TRUE : FALSE;
+ return !!(m_pEdit->ClearSelections() == FWL_ERR_Succeeded);
}
FWL_ERR CFWL_ComboBoxImp::GetBBox(CFX_RectF& rect) {
if (m_pWidgetMgr->IsFormDisabled()) {

Powered by Google App Engine
This is Rietveld 408576698