core/src/fxcodec/codec/fx_codec_progress.cpp - Issue 1409323003: XFA: Remove cond ? TRUE : FALSE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcodec/codec/fx_codec_progress.cpp

Issue 1409323003: XFA: Remove cond ? TRUE : FALSE. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxcodec/codec/fx_codec_progress.cpp

diff --git a/core/src/fxcodec/codec/fx_codec_progress.cpp b/core/src/fxcodec/codec/fx_codec_progress.cpp

index 0ad4c2a6681116531d1aca6e0c119da460860173..1ce4c2936ab9e0b31af22efb6c50b3b15f0a11ad 100644

--- a/core/src/fxcodec/codec/fx_codec_progress.cpp

+++ b/core/src/fxcodec/codec/fx_codec_progress.cpp

@@ -716,7 +716,7 @@ void CCodec_ProgressiveDecoder::GifReadScanlineCallback(void* pModule,

pal_index = pCodec->m_GifTransIndex;

}

FXSYS_memset(pCodec->m_pDecodeBuf, pal_index, pCodec->m_SrcWidth);

- FX_BOOL bLastPass = ((row_num % 2) == 1) ? TRUE : FALSE;

+ FX_BOOL bLastPass = ((row_num % 2) == 1);

Tom Sepez 2015/10/19 20:16:10 nit: overparenthesized.

Lei Zhang 2015/10/20 00:41:43 Done.

int32_t line = row_num + pCodec->m_GifFrameRect.top;

int32_t left = pCodec->m_GifFrameRect.left;

FXSYS_memcpy(pCodec->m_pDecodeBuf + left, row_buf, img_width);

« no previous file with comments | « no previous file | xfa/src/fdp/src/fde/fde_gedevice.cpp » ('j') | xfa/src/fdp/src/tto/fde_textout.cpp » ('J')