Issue 14093019: Linux/CrOS: In the MTPDeviceDelegate, use the right variable when handling 0-byte files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14093019: Linux/CrOS: In the MTPDeviceDelegate, use the right variable when handling 0-byte files. (Closed)

Created:
7 years, 8 months ago by Lei Zhang

Modified:
7 years, 8 months ago

Reviewers:
vandebo (ex-Chrome)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Linux/CrOS: In the MTPDeviceDelegate, use the right variable when handling 0-byte files. BUG=232950 TEST=see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194725

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

https://codereview.chromium.org/14093019/diff/1/chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc File chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc (right): https://codereview.chromium.org/14093019/diff/1/chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc#newcode407 chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc:407: snapshot_file_info, current_snapshot_request_info_->snapshot_file_path); We just released |snapshot_request_info| 3 line up. ...

7 years, 8 months ago (2013-04-17 22:52:27 UTC) #1

Lei Zhang

7 years, 8 months ago (2013-04-17 23:49:00 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r194725 (presubmit successful).

Expand Messages | Collapse Messages