Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 14093008: Adding a bit of rebustness to SkRectShaderImageFilter (Closed)

Created:
7 years, 8 months ago by sugoi1
Modified:
7 years, 8 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Adding a bit of rebustness to SkRectShaderImageFilter Since SkRectShaderImageFilter is an image filter, I added logic so that it can actually use the size of an input image as the rect if an empty rect is provided as an argument. I also added logic to prevent creating an empty device. Committed: https://code.google.com/p/skia/source/detail?r=8739

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M src/effects/SkRectShaderImageFilter.cpp View 1 1 chunk +16 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sugoi1
7 years, 8 months ago (2013-04-17 17:47:53 UTC) #1
Stephen White
https://codereview.chromium.org/14093008/diff/1/src/effects/SkRectShaderImageFilter.cpp File src/effects/SkRectShaderImageFilter.cpp (right): https://codereview.chromium.org/14093008/diff/1/src/effects/SkRectShaderImageFilter.cpp#newcode52 src/effects/SkRectShaderImageFilter.cpp:52: SkBitmap src = this->getInputResult(0, proxy, source, ctm, loc); This ...
7 years, 8 months ago (2013-04-17 17:59:39 UTC) #2
Stephen White
LGTM
7 years, 8 months ago (2013-04-17 22:28:02 UTC) #3
sugoi1
7 years, 8 months ago (2013-04-18 14:13:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r8739 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698