Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 14093007: support CC/CXX_wrapper in chromium.gyp_env (Closed)

Created:
7 years, 8 months ago by scottmg
Modified:
7 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

support CC/CXX_wrapper in chromium.gyp_env See https://codereview.chromium.org/13950005/ for where it's required. R=thakis@chromium.org BUG=232421 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/gyp_helper.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
7 years, 8 months ago (2013-04-17 17:39:37 UTC) #1
Nico
lgtm
7 years, 8 months ago (2013-04-17 17:51:03 UTC) #2
scottmg
7 years, 8 months ago (2013-04-17 21:16:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r194679 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698