new URL('') should throw TypeError

components/autofill/content/renderer/form_autofill_util.cc

Index: components/autofill/content/renderer/form_autofill_util.cc
diff --git a/components/autofill/content/renderer/form_autofill_util.cc b/components/autofill/content/renderer/form_autofill_util.cc
index 807a0d1e6bf8ea200228f63ef96d93000f890c73..9521d669323d8eea82dcfe06219ad6dcae164b01 100644
--- a/components/autofill/content/renderer/form_autofill_util.cc
+++ b/components/autofill/content/renderer/form_autofill_util.cc
@@ -1121,7 +1121,8 @@ bool IsFormVisible(blink::WebFrame* frame,
   frame->document().forms(forms);
 
 #if !defined(OS_MACOSX) && !defined(OS_ANDROID)
-  const bool action_is_empty = canonical_action == canonical_origin;
+  const bool action_is_empty = canonical_action == canonical_origin

[vabr (Chromium), 2015/11/06 11:24:14]

nit: Could you please comment that omitting the action attribute would result in
|canonical_origin| for hierarchical schemes like http:, and in an empty URL for
non-hierarchical schemes like about: or data:? (Also: is that true? :))

[ramya.v, 2015/11/06 13:45:14]

Done.

+                               || canonical_action.is_empty();

[vabr (Chromium), 2015/11/06 11:24:14]

Could you swap the order of the checks, so that is_empty() goes before the
string equality? is_empty is much quicker, could spare some time in cases where
it is true, and won't add significant overhead in the rest.

(Also on lines 1141-1142.)

[ramya.v, 2015/11/06 13:45:14]

Done.

 #endif
 
   // Since empty or unspecified action fields are automatically set to page URL,
@@ -1137,7 +1138,8 @@ bool IsFormVisible(blink::WebFrame* frame,
 
     GURL iter_canonical_action = GetCanonicalActionForForm(form);
 #if !defined(OS_MACOSX) && !defined(OS_ANDROID)
-    bool form_action_is_empty = iter_canonical_action == frame_url;
+    bool form_action_is_empty = iter_canonical_action == frame_url
+                                || iter_canonical_action.is_empty();
 
     if (action_is_empty != form_action_is_empty)
       continue;