new URL('') should throw TypeError

chrome/renderer/autofill/password_autofill_agent_browsertest.cc

Index: chrome/renderer/autofill/password_autofill_agent_browsertest.cc
diff --git a/chrome/renderer/autofill/password_autofill_agent_browsertest.cc b/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
index 4639049ee38cc9edc21d1f2ed0585e8d519f1858..0143c5047b6f2b8f88c81e281397fbdd2c628961 100644
--- a/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
+++ b/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
@@ -553,7 +553,7 @@ TEST_F(PasswordAutofillAgentTest, InitialAutocompleteForEmptyAction) {
 
   // Set the expected form origin and action URLs.
   UpdateOriginForHTML(kEmptyActionFormHTML);
-  fill_data_.action = fill_data_.origin;
+  fill_data_.action = GURL("");

[vabr (Chromium), 2015/11/06 11:24:14]

Does GURL() and GURL("") result in the same object? If so, please use GURL().
Otherwise, please at least replace "" with std::string().

[ramya.v, 2015/11/06 13:45:14]

Done.

 
   // Simulate the browser sending back the login info, it triggers the
   // autocomplete.
@@ -1400,7 +1400,7 @@ TEST_F(PasswordAutofillAgentTest,
 TEST_F(PasswordAutofillAgentTest,
        RememberLastNonEmptyUsernameAndPasswordOnSubmit_New) {
   const char kNewPasswordFormHTML[] =
-      "<FORM name='LoginTestForm'>"
+      "<FORM name='LoginTestForm' action='http://www.bidule.com'>"

[vabr (Chromium), 2015/11/06 11:24:14]

What exactly went wrong with this test when the action was not specified?

[ramya.v, 2015/11/06 13:45:14]

In PasswordAutofillAgent::WillSubmitForm
submitted_form is coming null because of the following logic in
CreatePasswordFormFromWebForm.
 password_form->action = form_util::GetCanonicalActionForForm(web_form);
  if (!password_form->action.is_valid())
    return scoped_ptr<PasswordForm>();

Hence IPC msg is not sent back and the test is failing.

[vabr (Chromium), 2015/11/06 14:08:54]

Acknowledged.

       "  <INPUT type='text' id='username' autocomplete='username'/>"
       "  <INPUT type='password' id='password' autocomplete='new-password'/>"
       "  <INPUT type='submit' value='Login'/>"