chrome/renderer/autofill/password_generation_agent_browsertest.cc - Issue 1409293007: new URL('') should throw TypeError

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/autofill/password_generation_agent_browsertest.cc

Issue 1409293007: new URL('') should throw TypeError (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated testcase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/autofill/password_generation_agent_browsertest.cc

diff --git a/chrome/renderer/autofill/password_generation_agent_browsertest.cc b/chrome/renderer/autofill/password_generation_agent_browsertest.cc

index cd8e276aa6e8556a188e7f57e636d9071b93deb5..118576e868fb8a0155c4bea4bb1335d5b4d626fd 100644

--- a/chrome/renderer/autofill/password_generation_agent_browsertest.cc

+++ b/chrome/renderer/autofill/password_generation_agent_browsertest.cc

@@ -449,6 +449,7 @@ TEST_F(PasswordGenerationAgentTest, DynamicFormTest) {

ExecuteJavaScriptForTests(

"var form = document.createElement('form');"

+ "form.action='http://www.random.com';"

"var username = document.createElement('input');"

"username.type = 'text';"

"username.id = 'dynamic_username';"