new URL('') should throw TypeError

chrome/renderer/autofill/password_autofill_agent_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/renderer/autofill/password_generation_test_utils.h"
 #include "chrome/test/base/chrome_render_view_test.h"
 #include "components/autofill/content/common/autofill_messages.h"
 #include "components/autofill/content/renderer/autofill_agent.h"
@@ skipping 535 matching lines @@
   WebElement element =
       document.getElementById(WebString::fromUTF8(kUsernameName));
   ASSERT_FALSE(element.isNull());
   username_element_ = element.to<blink::WebInputElement>();
   element = document.getElementById(WebString::fromUTF8(kPasswordName));
   ASSERT_FALSE(element.isNull());
   password_element_ = element.to<blink::WebInputElement>();
 
   // Set the expected form origin and action URLs.
   UpdateOriginForHTML(kEmptyActionFormHTML);
-  fill_data_.action = fill_data_.origin;
+  fill_data_.action = GURL("");

[vabr (Chromium), 2015/11/06 11:24:14]

Does GURL() and GURL("") result in the same object? If so, please use GURL().
Otherwise, please at least replace "" with std::string().

[ramya.v, 2015/11/06 13:45:14]

Done.

 
   // Simulate the browser sending back the login info, it triggers the
   // autocomplete.
   SimulateOnFillPasswordForm(fill_data_);
 
   // The username and password should have been autocompleted.
   CheckTextFieldsState(kAliceUsername, true, kAlicePassword, true);
 }
 
 // Tests that if a password is marked as readonly, neither field is autofilled
@@ skipping 826 matching lines @@
   // Observe that the PasswordAutofillAgent respects the user having cleared the
   // password.
   ExpectFormSubmittedWithUsernameAndPasswords("", "", "");
 }
 
 // Similar to RememberLastNonEmptyPasswordOnSubmit_ScriptCleared, but uses the
 // new password instead of the current password.
 TEST_F(PasswordAutofillAgentTest,
        RememberLastNonEmptyUsernameAndPasswordOnSubmit_New) {
   const char kNewPasswordFormHTML[] =
-      "<FORM name='LoginTestForm'>"
+      "<FORM name='LoginTestForm' action='http://www.bidule.com'>"

[vabr (Chromium), 2015/11/06 11:24:14]

What exactly went wrong with this test when the action was not specified?

[ramya.v, 2015/11/06 13:45:14]

In PasswordAutofillAgent::WillSubmitForm
submitted_form is coming null because of the following logic in
CreatePasswordFormFromWebForm.
 password_form->action = form_util::GetCanonicalActionForForm(web_form);
  if (!password_form->action.is_valid())
    return scoped_ptr<PasswordForm>();

Hence IPC msg is not sent back and the test is failing.

[vabr (Chromium), 2015/11/06 14:08:54]

Acknowledged.

       "  <INPUT type='text' id='username' autocomplete='username'/>"
       "  <INPUT type='password' id='password' autocomplete='new-password'/>"
       "  <INPUT type='submit' value='Login'/>"
       "</FORM>";
   LoadHTML(kNewPasswordFormHTML);
   UpdateUsernameAndPasswordElements();
 
   SimulateUsernameChange("temp");
   SimulatePasswordChange("random");
 
@@ skipping 875 matching lines @@
   UpdateOriginForHTML(kTwoNoUsernameFormsHTML);
   SimulateOnFillPasswordForm(fill_data_);
 
   SimulateElementClick("password1");
   CheckSuggestions(std::string(), false);
   SimulateElementClick("password2");
   CheckSuggestions(std::string(), false);
 }
 
 }  // namespace autofill