third_party/WebKit/LayoutTests/fast/domurl/url-constructor.html - Issue 1409293007: new URL('') should throw TypeError

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/domurl/url-constructor.html

Issue 1409293007: new URL('') should throw TypeError (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated testcase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/autofill/content/renderer/form_autofill_util.cc ('k') | third_party/WebKit/LayoutTests/fast/url/script-tests/segments-from-data-url.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE HTML>	1 <!DOCTYPE HTML>

2 <link rel="help" href="http://url.spec.whatwg.org/#dom-url">	2 <link rel="help" href="http://url.spec.whatwg.org/#dom-url">

3 <script src="../../resources/testharness.js"></script>	3 <script src="../../resources/testharness.js"></script>

4 <script src="../../resources/testharnessreport.js"></script>	4 <script src="../../resources/testharnessreport.js"></script>

5 <script>	5 <script>

6	6

7 function assertThrows(func, expected) {	7 function assertThrows(func, expected) {

8 try {	8 try {

9 func();	9 func();

10 } catch (ex) {	10 } catch (ex) {

(...skipping 14 matching lines...) Expand all Loading...
25 // Unmatched surrogate handling	25 // Unmatched surrogate handling

26 var encodedReplacementCharacter = encodeURIComponent('\ufffd');	26 var encodedReplacementCharacter = encodeURIComponent('\ufffd');

27 assert_equals(new URL('b/c', 'http://www.domain.com/\ud801/b').toString(), ' http://www.domain.com/' + encodedReplacementCharacter + '/b/c');	27 assert_equals(new URL('b/c', 'http://www.domain.com/\ud801/b').toString(), ' http://www.domain.com/' + encodedReplacementCharacter + '/b/c');

28 }, 'Valid URLs');	28 }, 'Valid URLs');

29	29

30 test(function() {	30 test(function() {

31 assertThrows(function() {	31 assertThrows(function() {

32 new URL();	32 new URL();

33 }, 'TypeError: Failed to construct \'URL\': 1 argument required, but only 0 present.');	33 }, 'TypeError: Failed to construct \'URL\': 1 argument required, but only 0 present.');

34 assertThrows(function() {	34 assertThrows(function() {

	35 new URL('');

	36 }, 'TypeError: Failed to construct \'URL\': Invalid URL');

	37 assertThrows(function() {

	38 new URL('','about:blank');

	39 }, 'TypeError: Failed to construct \'URL\': Invalid URL');

	40 assertThrows(function() {

35 new URL('abc');	41 new URL('abc');

36 }, 'TypeError: Failed to construct \'URL\': Invalid URL');	42 }, 'TypeError: Failed to construct \'URL\': Invalid URL');

37 assertThrows(function() {	43 assertThrows(function() {

38 new URL('//abc');	44 new URL('//abc');

39 }, 'TypeError: Failed to construct \'URL\': Invalid URL');	45 }, 'TypeError: Failed to construct \'URL\': Invalid URL');

40 assertThrows(function() {	46 assertThrows(function() {

41 new URL('http:///www.domain.com/', 'abc');	47 new URL('http:///www.domain.com/', 'abc');

42 }, 'TypeError: Failed to construct \'URL\': Invalid base URL');	48 }, 'TypeError: Failed to construct \'URL\': Invalid base URL');

43 assertThrows(function() {	49 assertThrows(function() {

44 new URL('http:///www.domain.com/', null);	50 new URL('http:///www.domain.com/', null);

45 }, 'TypeError: Failed to construct \'URL\': Invalid base URL');	51 }, 'TypeError: Failed to construct \'URL\': Invalid base URL');

46 }, 'Invalid URL parameters');	52 }, 'Invalid URL parameters');

47	53

48 </script>	54 </script>

OLD	NEW