Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 1409273006: SkRemote: fix Misc hash function. (Closed)

Created:
5 years, 2 months ago by mtklein_C
Modified:
5 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkRemote: fix Misc hash function. Misc only has data in the first 10 bytes of its 12 byte layout. We need to stop hashing at 10 bytes. C.f. http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Valgrind/builds/581 BUG=skia: Committed: https://skia.googlesource.com/skia/+/deb8146fac665d78f9a1fe745389807d69a79142

Patch Set 1 #

Patch Set 2 : clearer? #

Patch Set 3 : illegal sizeof #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M src/core/SkRemote.cpp View 1 2 3 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409273006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409273006/20001
5 years, 2 months ago (2015-10-19 21:11:02 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/3761) Build-Win-MSVC-x86_64-Debug-Trybot on ...
5 years, 2 months ago (2015-10-19 21:13:03 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409273006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409273006/40001
5 years, 2 months ago (2015-10-19 21:30:23 UTC) #7
mtklein_C
5 years, 2 months ago (2015-10-19 21:31:31 UTC) #10
hal.canary
On 2015/10/19 21:31:31, mtklein_C wrote: Lgtm. I hope offsetof works everywhere.
5 years, 2 months ago (2015-10-19 21:34:07 UTC) #11
mtklein
> Lgtm. I hope offsetof works everywhere. ?
5 years, 2 months ago (2015-10-19 21:34:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409273006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409273006/40001
5 years, 2 months ago (2015-10-19 21:34:46 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/deb8146fac665d78f9a1fe745389807d69a79142
5 years, 2 months ago (2015-10-19 21:39:49 UTC) #16
mtklein_C
5 years, 2 months ago (2015-10-20 13:49:27 UTC) #17
Message was sent while issue was closed.
This fixed DM.  Nanobench is still failing, but SkRemote isn't plugged in there
yet.  I'll see if I can figure out what's up there anyway.

Powered by Google App Engine
This is Rietveld 408576698