Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1409273005: [turbofan] Use correct map for special JSObject accessors. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use correct map for special JSObject accessors. This fixes a small inconsistency when the accessor is on a prototype, because the property access has to respect the holder (and not always go to the receiver unconditionally). R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/6367c0798ee297a9319de539e0073035785c1185 Cr-Commit-Position: refs/heads/master@{#31375}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M src/compiler/js-native-context-specialization.cc View 4 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 2 months ago (2015-10-19 12:20:01 UTC) #1
Jarin
lgtm
5 years, 2 months ago (2015-10-19 12:30:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409273005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409273005/1
5 years, 2 months ago (2015-10-19 12:34:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 13:25:00 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 13:25:31 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6367c0798ee297a9319de539e0073035785c1185
Cr-Commit-Position: refs/heads/master@{#31375}

Powered by Google App Engine
This is Rietveld 408576698