Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1409273004: SkRemote: simple impl of onDraw*Text* (Closed)

Created:
5 years, 2 months ago by hal.canary
Modified:
5 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase && add comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M src/core/SkRemote.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/core/SkRemote.cpp View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
halcanary_use_other_email
ptal
5 years, 2 months ago (2015-10-17 02:29:24 UTC) #2
mtklein
lgtm https://codereview.chromium.org/1409273004/diff/1/src/core/SkRemote.cpp File src/core/SkRemote.cpp (left): https://codereview.chromium.org/1409273004/diff/1/src/core/SkRemote.cpp#oldcode209 src/core/SkRemote.cpp:209: //Text-as-paths is a temporary hack. //TODO: send SkTextBlobs ...
5 years, 2 months ago (2015-10-17 12:57:45 UTC) #3
hal.canary
https://codereview.chromium.org/1409273004/diff/1/src/core/SkRemote.cpp File src/core/SkRemote.cpp (left): https://codereview.chromium.org/1409273004/diff/1/src/core/SkRemote.cpp#oldcode209 src/core/SkRemote.cpp:209: On 2015/10/17 12:57:45, mtklein wrote: > //Text-as-paths is a ...
5 years, 2 months ago (2015-10-17 22:37:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409273004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409273004/20001
5 years, 2 months ago (2015-10-17 22:37:24 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-17 22:46:32 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f27106983048e7db5361bcc0cacc9d39d632817d

Powered by Google App Engine
This is Rietveld 408576698