Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1409273002: LookupScope does not need to be in SkRemote.h (Closed)

Created:
5 years, 2 months ago by mtklein_C
Modified:
5 years, 2 months ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

LookupScope does not need to be in SkRemote.h It's only used by Cache and Client. This moves it to SkRemote.cpp, where they live. BUG=skia: Committed: https://skia.googlesource.com/skia/+/56f152b53f911b578e305d3461fb001585984a67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -25 lines) Patch
M src/core/SkRemote.h View 1 chunk +1 line, -16 lines 0 comments Download
M src/core/SkRemote.cpp View 2 chunks +22 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein
5 years, 2 months ago (2015-10-16 22:15:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409273002/1
5 years, 2 months ago (2015-10-16 22:15:55 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 2 months ago (2015-10-16 22:15:56 UTC) #5
hal.canary
lgtm
5 years, 2 months ago (2015-10-16 22:32:53 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 22:33:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/56f152b53f911b578e305d3461fb001585984a67

Powered by Google App Engine
This is Rietveld 408576698