Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 1409253007: Scope cleanup: remove unused bits and accessors (Closed)

Created:
5 years, 1 month ago by adamk
Modified:
5 years, 1 month ago
Reviewers:
Dan Ehrenberg
CC:
rossberg, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Scope cleanup: remove unused bits and accessors - inner_scope_uses_arguments_ was completely unused - The public accessor for contains_with() was not called - inside_with() had helper methods on Parser and PatternRewriter, but was only called in one place. Committed: https://crrev.com/a6ef1ea8aea37090906eb96e90b9476157c1df16 Cr-Commit-Position: refs/heads/master@{#31587}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -25 lines) Patch
M src/parser.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/pattern-rewriter.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/scopes.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/scopes.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
5 years, 1 month ago (2015-10-27 00:08:20 UTC) #2
Dan Ehrenberg
lgtm Yay!
5 years, 1 month ago (2015-10-27 00:15:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409253007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409253007/1
5 years, 1 month ago (2015-10-27 00:46:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 00:47:45 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 00:48:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6ef1ea8aea37090906eb96e90b9476157c1df16
Cr-Commit-Position: refs/heads/master@{#31587}

Powered by Google App Engine
This is Rietveld 408576698