SkRemote: impl drawPaint()

SkRemote: impl drawPaint()

Committed: https://skia.googlesource.com/skia/+/1ed348aea37e34dd0ad3bde33cd28bcbd1c2a587

[halcanary_use_other_email, 2015-10-17 02:11:46]

halcanary@gmail.com changed reviewers:
+ halcanary@gmail.com, mtklein@google.com

[mtklein, 2015-10-17 12:52:53]

lgtm

[hal.canary, 2015-10-17 13:01:55]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-10-17 13:02:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1409253003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1409253003/1

[commit-bot: I haz the power, 2015-10-17 13:11:57]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1ed348aea37e34dd0ad3bde33cd28bcbd1c2a587

[reed1, 2015-10-19 13:28:55]

reed@google.com changed reviewers:
+ reed@google.com

[reed1, 2015-10-19 13:28:56]

https://codereview.chromium.org/1409253003/diff/1/src/core/SkRemote.cpp
File src/core/SkRemote.cpp (right):

https://codereview.chromium.org/1409253003/diff/1/src/core/SkRemote.cpp#newco...
src/core/SkRemote.cpp:211: this->onDrawRect(SkRect::MakeLargest(), paint);
temporary I presume?

this is not a completely safe way to impl drawPaint. consider if the matrix
scales up (we'd get infinities) or some forms of perspective where this would
give nonsense results.

[mtklein, 2015-10-19 14:05:12]

On 2015/10/19 13:28:56, reed1 wrote:
> https://codereview.chromium.org/1409253003/diff/1/src/core/SkRemote.cpp
> File src/core/SkRemote.cpp (right):
> 
>
https://codereview.chromium.org/1409253003/diff/1/src/core/SkRemote.cpp#newco...
> src/core/SkRemote.cpp:211: this->onDrawRect(SkRect::MakeLargest(), paint);
> temporary I presume?
> 
> this is not a completely safe way to impl drawPaint. consider if the matrix
> scales up (we'd get infinities) or some forms of perspective where this would
> give nonsense results.

yes, temporary hack.