Make ImageBitmap Transferable

third_party/WebKit/Source/core/frame/ImageBitmap.cpp

Index: third_party/WebKit/Source/core/frame/ImageBitmap.cpp
diff --git a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
index bb45b3f009b97649d272ffb1158c13e864aee62a..4d656e53e7e21f143c5dae9c963778e5e30c3cc4 100644
--- a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
+++ b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
@@ -181,6 +181,19 @@ PassRefPtrWillBeRawPtr<ImageBitmap> ImageBitmap::create(Image* image, const IntR
     return adoptRefWillBeNoop(new ImageBitmap(image, normalizedCropRect));
 }
 
+void ImageBitmap::neuter()

[Justin Novosad, 2015/10/24 03:04:48]

I don't see why neuter and transfer need to be separate functions. Semantically
transfer means make a shallow copy and neuter the original. Right now transfer()
only does the copy part, which is misleading. IMHO we should just have one
method named 'transfer' that does all the work. If there is a legitimate reason
to have both methods, then they should be named 'neuter' and 'shallowCopy'.

[xidachen, 2015/10/24 20:36:25]

That makes perfect sense. They are now merged into one function "transfer".

+{
+    if (m_imageElement)
+        m_imageElement.clear();
+    if (m_bitmap)
+        m_bitmap.clear();
+}
+
+PassRefPtrWillBeRawPtr<ImageBitmap> ImageBitmap::transfer()
+{
+    return adoptRefWillBeNoop(new ImageBitmap(this, m_cropRect));
+}
+
 void ImageBitmap::notifyImageSourceChanged()
 {
     m_bitmap = cropImage(m_imageElement->cachedImage()->image(), m_cropRect);