Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1409243004: Add FPDFAPIJPEG_ prefix to more libjpeg functions (Closed)

Created:
5 years, 2 months ago by Evangelos Foutras
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add FPDFAPIJPEG_ prefix to more libjpeg functions Original patch by Evangelos Foutras. Chromium built with use_system_libjpeg=1 can mistakenly try to use symbols exported by the libjpeg library that's bundled with pdfium. These name conflicts result in failure to encode the contents of a canvas element using toDataURL('image/jpeg'). BUG=505226 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/1b5084321ed924ad3fcc437c3effc81baafd18ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
M core/include/thirdparties/libjpeg/jpeglib.h View 3 chunks +35 lines, -0 lines 0 comments Download
M third_party/libjpeg/jpeglib.h View 3 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Evangelos Foutras
5 years, 2 months ago (2015-10-19 09:36:07 UTC) #2
Evangelos Foutras
While I'm not 100% sure this is the correct fix, it seems like a reasonable ...
5 years, 2 months ago (2015-10-19 10:02:28 UTC) #3
Tom Sepez
On 2015/10/19 10:02:28, foutrelis wrote: > While I'm not 100% sure this is the correct ...
5 years, 2 months ago (2015-10-19 16:16:08 UTC) #4
Evangelos Foutras
On 2015/10/19 16:16:08, Tom Sepez wrote: > Thanks for tracking down the missing prefixes. Given ...
5 years, 2 months ago (2015-10-19 17:59:39 UTC) #5
Tom Sepez
5 years, 2 months ago (2015-10-19 18:50:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b5084321ed924ad3fcc437c3effc81baafd18ac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698