Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 1409243003: Revert of Implement $Secure- cookie prefix (Closed)

Created:
5 years, 2 months ago by Mattias Nissler (ping if slow)
Modified:
5 years, 2 months ago
CC:
cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, extensions-reviews_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement $Secure- cookie prefix (patchset #16 id:420001 of https://codereview.chromium.org/1393193005/ ) Reason for revert: Broke net_unittests on Android: I 63.275s run_tests_on_device(06b2a92a003bca26) [ RUN ] URLRequestTest.SecureCookiePrefixOnNonsecureOrigin I 63.275s run_tests_on_device(06b2a92a003bca26) [ERROR:spawner_communicator.cc(241)] request failed, status: 3, error: -324 I 63.275s run_tests_on_device(06b2a92a003bca26) ../../net/url_request/url_request_unittest.cc:2737: Failure I 63.276s run_tests_on_device(06b2a92a003bca26) Value of: test_server_https.Start() I 63.276s run_tests_on_device(06b2a92a003bca26) Actual: false I 63.276s run_tests_on_device(06b2a92a003bca26) Expected: true I 63.276s run_tests_on_device(06b2a92a003bca26) [ERROR:spawner_communicator.cc(241)] request failed, status: 3, error: -324 I 63.276s run_tests_on_device(06b2a92a003bca26) [ FAILED ] URLRequestTest.SecureCookiePrefixOnNonsecureOrigin (487 ms) http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/30742 http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/22819 Original issue's description: > Implement $Secure- cookie prefix > > This CL implements the rule that cookies whose names start with > $Secure- can only be set if the Secure attribute is enabled. The > implementation is a runtime-enabled web platform feature for now. > > Intent to Implement: > https://groups.google.com/a/chromium.org/d/msg/blink-dev/IU5t6eLuS2Y/Uq-7Kat9BwAJ > > BUG=541511 > TBR=droger@chromium.org > > Committed: https://crrev.com/467a098174e062d4380eb0ad8f7b2f0b0b7ed5fa > Cr-Commit-Position: refs/heads/master@{#354676} TBR=mkwst@chromium.org,jochen@chromium.org,mmenke@chromium.org,droger@chromium.org,estark@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=541511 Committed: https://crrev.com/c236d3b2efe063dc0914e2bebdb4c28cac7fa6c2 Cr-Commit-Position: refs/heads/master@{#354736}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -269 lines) Patch
M chrome/browser/android/cookies/cookies_fetcher.cc View 2 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M content/browser/frame_host/render_frame_message_filter.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M ios/net/cookies/cookie_store_ios_unittest.mm View 3 chunks +0 lines, -3 lines 0 comments Download
M net/cookies/cookie_monster.h View 2 chunks +0 lines, -2 lines 0 comments Download
M net/cookies/cookie_monster.cc View 9 chunks +2 lines, -22 lines 0 comments Download
M net/cookies/cookie_monster_unittest.cc View 5 chunks +4 lines, -28 lines 0 comments Download
M net/cookies/cookie_options.h View 2 chunks +0 lines, -6 lines 0 comments Download
M net/cookies/cookie_options.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/cookies/cookie_store_unittest.h View 2 chunks +0 lines, -5 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 2 chunks +0 lines, -180 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mattias Nissler (ping if slow)
Created Revert of Implement $Secure- cookie prefix
5 years, 2 months ago (2015-10-19 08:07:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409243003/1
5 years, 2 months ago (2015-10-19 08:07:58 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 08:08:51 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 08:09:47 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c236d3b2efe063dc0914e2bebdb4c28cac7fa6c2
Cr-Commit-Position: refs/heads/master@{#354736}

Powered by Google App Engine
This is Rietveld 408576698