Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 140923005: Revert of Created new Windows LevelDB environment. (Closed)

Created:
6 years, 11 months ago by cmumford
Modified:
6 years, 11 months ago
CC:
chromium-reviews, jam, alecflett, joi+watch-content_chromium.org, darin-cc_chromium.org, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Created new Windows LevelDB environment. (https://codereview.chromium.org/113373002/) Reason for revert: The indexeddb_perf tests on all Windows testers regressed in performance significantly. Don't yet know the exact cause, but because the performance drop is significant will revert this change first, and then proceed with the investigation. Original issue's description: > Created new Win32 LevelDB environment. > > This change splits ChromiumEnv into two classes: ChromiumEnv/ChromiumEnvPosix. > ChromiumEnvWin32 was also added which uses the Win32 API - except for logging. > > The default is to create POSIX environments for all platforms for non-IDB > LevelDB users. For IDB we create a Windows environment on Windows, else a > POSIX environment like before. > > BUG=222623 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245135 TBR=dgrogan@chromium.org,alecflett@chromium.org,jsbell@chromium.org,iannucci@chromium.org NOTREECHECKS=true NOTRY=true BUG=222623 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245270

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+484 lines, -1032 lines) Patch
M third_party/leveldatabase/env_chromium.h View 4 chunks +50 lines, -16 lines 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 7 chunks +430 lines, -78 lines 0 comments Download
D third_party/leveldatabase/env_chromium_stdio.h View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/leveldatabase/env_chromium_stdio.cc View 1 chunk +0 lines, -380 lines 0 comments Download
M third_party/leveldatabase/env_chromium_unittest.cc View 4 chunks +4 lines, -36 lines 0 comments Download
D third_party/leveldatabase/env_chromium_win.h View 1 chunk +0 lines, -79 lines 0 comments Download
D third_party/leveldatabase/env_chromium_win.cc View 1 chunk +0 lines, -362 lines 0 comments Download
M third_party/leveldatabase/leveldatabase.gyp View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cmumford
Created Revert of Created new Windows LevelDB environment.
6 years, 11 months ago (2014-01-16 18:36:55 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 11 months ago (2014-01-16 18:38:59 UTC) #2
jsbell
lgtm
6 years, 11 months ago (2014-01-16 18:39:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/140923005/1
6 years, 11 months ago (2014-01-16 18:40:11 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 18:46:22 UTC) #5
Message was sent while issue was closed.
Change committed as 245270

Powered by Google App Engine
This is Rietveld 408576698