Issue 140923003: Remove unused include file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140923003: Remove unused include file (Closed)

Created:
6 years, 11 months ago by riju_

Modified:
6 years, 9 months ago

Reviewers:
reveman

CC:
chromium-reviews, cc-bugs_chromium.org, sohanjg, Ken Russell (switch to Gerrit)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove unused include file "third_party/khronos/GLES2/gl2.h" was included in the raster_worker_pool.h which caused conflict due to macro expansion of glShaderSource found it while debugging Issue #73923003 which was failing on mac bots

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	cc/resources/raster_worker_pool.h	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rijubrata.bhaumik@intel.com/140923003/1

6 years, 11 months ago (2014-01-16 16:44:01 UTC) #3

jamesr

This is unfortunate - anyone using the compositor's interface should be able to see the ...

6 years, 11 months ago (2014-01-16 19:05:50 UTC) #4

reveman

6 years, 11 months ago (2014-01-16 19:42:22 UTC) #5

cq-

This include is not actually unused. We need it for GLenum. If it really turns
out that this include can't be here then change this GLenum to an int or
unsigned before you remove the include. Preferably we make it possible to have
this include here.

Expand Messages | Collapse Messages