chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm - Issue 1409223005: Change the password bubble on Mac so the columns are resized dynamically.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

Issue 1409223005: Change the password bubble on Mac so the columns are resized dynamically. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix the crash Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.h ('k') | chrome/browser/ui/cocoa/passwords/password_item_views.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

diff --git a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

index 5654ff5b1ae9d08239217405697c22b180a82cda..5e65bde24933bd67a752327f837c5da52ea3ab23 100644

--- a/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

+++ b/chrome/browser/ui/cocoa/passwords/manage_passwords_bubble_pending_view_controller.mm

@@ -137,10 +137,11 @@ const SkColor kWarmWelcomeColor = SkColorSetRGB(0x64, 0x64, 0x64);

// Password item.

// It should be at least as wide as the box without the padding.

- passwordItem_.reset([[ManagePasswordItemViewController alloc]

+ std::vector<const autofill::PasswordForm*> password_forms;

+ password_forms.push_back(&model_->pending_password());

+ passwordItem_.reset([[PasswordsListViewController alloc]

initWithModel:model_

- passwordForm:model_->pending_password()

- position:password_manager::ui::FIRST_ITEM]);

+ forms:password_forms]);

NSView* password = [passwordItem_ view];

[view addSubview:password];