third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl - Issue 1409223004: mandoline: Add automatic tracing at mojo call sites.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

Issue 1409223004: mandoline: Add automatic tracing at mojo call sites. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Safety rebase to ToT Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/mojo/src/mojo/public/interfaces/bindings/tests/sample_service.mojom ('k') | third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/module.cc.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

diff --git a/third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl b/third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

index a06d8496de7b5d185444e28b1ce41438c9520a57..15464ceea621d4e2a02910c563c63feba75b35fb 100644

--- a/third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

+++ b/third_party/mojo/src/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl

@@ -194,6 +194,7 @@ bool {{class_name}}Stub::Accept(mojo::Message* message) {

// A null |sink_| means no implementation was bound.

assert(sink_);

+ TRACE_EVENT0("mojom", "{{class_name}}::{{method.name}}");

sink_->{{method.name}}({{pass_params(method.parameters)}});

return true;

{%- else %}

@@ -228,6 +229,7 @@ bool {{class_name}}Stub::AcceptWithResponder(

// A null |sink_| means no implementation was bound.

assert(sink_);

+ TRACE_EVENT0("mojom", "{{class_name}}::{{method.name}}");

sink_->{{method.name}}(

{%- if method.parameters -%}{{pass_params(method.parameters)}}, {% endif -%}callback);

return true;