Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1409223002: fxcrt convergence - XFA side. (Closed)

Created:
5 years, 2 months ago by Tom Sepez
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

fxcrt convergence - XFA side. Take extern tables portion only of fx_bidi change. Take itoa fixes and corresponding unit test. Merge typo in skia font mgr. Kill some null checks after new. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/24e733ef26280268ac6ede6d73fac7475aedd1a9

Patch Set 1 #

Patch Set 2 : Stray file. #

Total comments: 6

Patch Set 3 : GN. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+274 lines, -126 lines) Patch
M BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M core/include/fxcrt/fx_ucd.h View 1 chunk +29 lines, -19 lines 0 comments Download
M core/src/fxcrt/fx_arabic.cpp View 4 chunks +13 lines, -14 lines 0 comments Download
M core/src/fxcrt/fx_basic_gcc.cpp View 3 chunks +23 lines, -15 lines 0 comments Download
A core/src/fxcrt/fx_system_unittest.cpp View 1 chunk +161 lines, -0 lines 0 comments Download
M core/src/fxcrt/fx_ucddata.cpp View 4 chunks +15 lines, -4 lines 0 comments Download
M core/src/fxcrt/fx_unicode.cpp View 2 chunks +12 lines, -15 lines 0 comments Download
M core/src/fxge/android/fpf_skiafontmgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/android/fpf_skiamodule.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fxge/android/fx_android_imp.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fxge/apple/fx_mac_imp.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fxge/dib/fx_dib_convert.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fxge/dib/fx_dib_engine.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M core/src/fxge/dib/fx_dib_transform.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M core/src/fxge/ge/fx_ge_linux.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/src/fxge/skia/fx_skia_device.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/win32/fx_win32_dwrite.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M core/src/fxge/win32/fx_win32_gdipext.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M core/src/fxge/win32/fx_win32_print.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M pdfium.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/src/fgas/src/layout/fx_linebreak.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M xfa/src/fgas/src/layout/fx_rtfbreak.cpp View 2 chunks +1 line, -4 lines 0 comments Download
M xfa/src/fgas/src/layout/fx_textbreak.cpp View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Tom Sepez
Lei, for review.
5 years, 2 months ago (2015-10-16 20:52:00 UTC) #2
Lei Zhang
I guess this will get a portion of the bidi/arabic CL that I never merged.
5 years, 2 months ago (2015-10-16 21:02:11 UTC) #3
Lei Zhang
lgtm, don't forget GN. https://codereview.chromium.org/1409223002/diff/20001/core/src/fxcrt/fx_system_unittest.cpp File core/src/fxcrt/fx_system_unittest.cpp (right): https://codereview.chromium.org/1409223002/diff/20001/core/src/fxcrt/fx_system_unittest.cpp#newcode1 core/src/fxcrt/fx_system_unittest.cpp:1: // Copyright 2015 PDFium Authors. ...
5 years, 2 months ago (2015-10-16 21:11:48 UTC) #4
Tom Sepez
Committed patchset #3 (id:40001) manually as 24e733ef26280268ac6ede6d73fac7475aedd1a9 (presubmit successful).
5 years, 2 months ago (2015-10-16 21:18:54 UTC) #5
Tom Sepez
5 years, 2 months ago (2015-10-16 21:29:44 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1409223002/diff/20001/core/src/fxcrt/fx_syste...
File core/src/fxcrt/fx_system_unittest.cpp (right):

https://codereview.chromium.org/1409223002/diff/20001/core/src/fxcrt/fx_syste...
core/src/fxcrt/fx_system_unittest.cpp:1: // Copyright 2015 PDFium Authors. All
rights reserved.
On 2015/10/16 21:11:48, Lei Zhang wrote:
> Make sure these tests pass locally?

Done.

https://codereview.chromium.org/1409223002/diff/20001/core/src/fxge/android/f...
File core/src/fxge/android/fpf_skiafontmgr.cpp (right):

https://codereview.chromium.org/1409223002/diff/20001/core/src/fxge/android/f...
core/src/fxge/android/fpf_skiafontmgr.cpp:340: pFont->Release();
On 2015/10/16 21:11:48, Lei Zhang wrote:
> We really need to set up more bots.

Acknowledged.

https://codereview.chromium.org/1409223002/diff/20001/pdfium.gyp
File pdfium.gyp (right):

https://codereview.chromium.org/1409223002/diff/20001/pdfium.gyp#newcode775
pdfium.gyp:775: 'core/src/fxcrt/fx_system_unittest.cpp',
On 2015/10/16 21:11:48, Lei Zhang wrote:
> GN as well.

Done.

Powered by Google App Engine
This is Rietveld 408576698