Issue 1409203002: Declare IndexableObject.file instead of Source.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1409203002: Declare IndexableObject.file instead of Source. (Closed)

Created:
5 years, 2 months ago by scheglov

Modified:
5 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Declare IndexableObject.file instead of Source. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/67576340b0d9a3670707851648584258f1ead7a4

Patch Set 2 : Use filePath name. #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -15 lines)			Patch
M	pkg/analysis_server/lib/plugin/index/index_core.dart	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/index.dart	View	1	4 chunks	+4 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/indexable_element.dart	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/store/codec.dart	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1409203002/diff/1/pkg/analysis_server/lib/plugin/index/index_core.dart File pkg/analysis_server/lib/plugin/index/index_core.dart (right): https://codereview.chromium.org/1409203002/diff/1/pkg/analysis_server/lib/plugin/index/index_core.dart#newcode39 pkg/analysis_server/lib/plugin/index/index_core.dart:39: String get file; I'd prefer filePath given that ...

5 years, 2 months ago (2015-10-16 20:47:37 UTC) #2

scheglov

5 years, 2 months ago (2015-10-16 21:43:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
67576340b0d9a3670707851648584258f1ead7a4 (presubmit successful).

Expand Messages | Collapse Messages

Issue 1409203002: Declare IndexableObject.file instead of Source. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Use filePath name. #

Messages