Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7708)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_action_view.h

Issue 1409183003: Adds ripple animation to extension buttons on a toolbar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adds ripple animation to extension buttons on a toolbar (gesture support) Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/toolbar_action_view.h
diff --git a/chrome/browser/ui/views/toolbar/toolbar_action_view.h b/chrome/browser/ui/views/toolbar/toolbar_action_view.h
index 19db601bd4259643ec4d5a6c19e8b5d3521556f4..6b1d634a0c6c2cec0ad2aa5d51cdaa56b8c88d71 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_action_view.h
+++ b/chrome/browser/ui/views/toolbar/toolbar_action_view.h
@@ -8,6 +8,7 @@
#include "chrome/browser/ui/views/toolbar/toolbar_action_view_delegate_views.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
+#include "ui/views/animation/ink_drop_host.h"
#include "ui/views/context_menu_controller.h"
#include "ui/views/controls/button/menu_button.h"
#include "ui/views/controls/button/menu_button_listener.h"
@@ -26,6 +27,7 @@ class Image;
}
namespace views {
+class InkDropAnimationController;
class MenuRunner;
}
@@ -37,7 +39,8 @@ class ToolbarActionView : public views::MenuButton,
public ToolbarActionViewDelegateViews,
public views::MenuButtonListener,
public views::ContextMenuController,
- public content::NotificationObserver {
+ public content::NotificationObserver,
+ public views::InkDropHost {
public:
// Need DragController here because ToolbarActionView could be
// dragged/dropped.
@@ -74,6 +77,7 @@ class ToolbarActionView : public views::MenuButton,
// views::MenuButtonListener:
void OnMenuButtonClicked(views::View* sender,
const gfx::Point& point) override;
+ void OnMenuButtonReleasedWithoutClick(views::View* sender) override;
// content::NotificationObserver:
void Observe(int type,
@@ -98,9 +102,24 @@ class ToolbarActionView : public views::MenuButton,
bool wants_to_run_for_testing() const { return wants_to_run_; }
+ // views::InkDropHost:
+ void AddInkDropLayer(ui::Layer* ink_drop_layer) override;
+ void RemoveInkDropLayer(ui::Layer* ink_drop_layer) override;
+
+ protected:
+ // Returns the Point where the ink drop should be centered.
+ virtual gfx::Point CalculateInkDropCenter() const;
+
+ views::InkDropAnimationController* ink_drop_animation_controller() {
+ return ink_drop_animation_controller_.get();
+ }
+
private:
// views::MenuButton:
gfx::Size GetPreferredSize() const override;
+ void Layout() override;
+ bool OnMousePressed(const ui::MouseEvent& event) override;
+ void OnGestureEvent(ui::GestureEvent* event) override;
void OnDragDone() override;
void ViewHierarchyChanged(
const ViewHierarchyChangedDetails& details) override;
@@ -146,6 +165,9 @@ class ToolbarActionView : public views::MenuButton,
// tab.
bool wants_to_run_;
+ // Indicates if menu is currently showing.
+ bool menu_showing_;
+
// Responsible for running the menu.
scoped_ptr<views::MenuRunner> menu_runner_;
@@ -158,6 +180,9 @@ class ToolbarActionView : public views::MenuButton,
content::NotificationRegistrar registrar_;
+ // Animation controller for the ink drop ripple effect.
+ scoped_ptr<views::InkDropAnimationController> ink_drop_animation_controller_;
+
base::WeakPtrFactory<ToolbarActionView> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(ToolbarActionView);

Powered by Google App Engine
This is Rietveld 408576698