More work for background compilation; move pending_functions_ from ObjectStore to Thread.

More work for background compilation; move pending_functions_ from ObjectStore to Thread.

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/8915fb6fde71acc29ef7f3600314befaf48f17c3

[srdjan, 2015-10-16 19:30:17]

srdjan@google.com changed reviewers:
+ asiva@google.com

[siva, 2015-10-16 23:29:40]

LGTM with some comments.

https://codereview.chromium.org/1409173002/diff/20001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1409173002/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1166: // compilation is on. OSR compilation still occura
in the main thread.
still occurs

https://codereview.chromium.org/1409173002/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1453: return Function::Cast(result).raw();
maybe just:

return RawFunction::RawCast(data_.At(data_.Length() - 1));

https://codereview.chromium.org/1409173002/diff/40001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1409173002/diff/40001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1473: while (running_) {
running_ is being accessed here without holding the queue_monitor lock?

https://codereview.chromium.org/1409173002/diff/40001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1485: while (!function.IsNull() && running_) {
Ditto question about running_ accessed here without holding the lock.

https://codereview.chromium.org/1409173002/diff/40001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1502: while (queue_length() == 0) {
while ((queue_length() == 0) && running_) {
}

[srdjan, 2015-10-16 23:50:17]

https://codereview.chromium.org/1409173002/diff/20001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1409173002/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1166: // compilation is on. OSR compilation still occura
in the main thread.
On 2015/10/16 23:29:40, siva wrote:
> still occurs

Done.

https://codereview.chromium.org/1409173002/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1453: return Function::Cast(result).raw();
On 2015/10/16 23:29:40, siva wrote:
> maybe just:
> 
> return RawFunction::RawCast(data_.At(data_.Length() - 1));

Done: Function::RawCast.

https://codereview.chromium.org/1409173002/diff/40001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1409173002/diff/40001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1473: while (running_) {
On 2015/10/16 23:29:40, siva wrote:
> running_ is being accessed here without holding the queue_monitor lock?

Yes, running_ is not guarded by queue lock. It can go only from true -> false,
therefore I do not think one is needed when reading it.

https://codereview.chromium.org/1409173002/diff/40001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1485: while (!function.IsNull() && running_) {
On 2015/10/16 23:29:40, siva wrote:
> Ditto question about running_ accessed here without holding the lock.

ditto.

https://codereview.chromium.org/1409173002/diff/40001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1502: while (queue_length() == 0) {
On 2015/10/16 23:29:40, siva wrote:
> while ((queue_length() == 0) && running_) {
> }

Done.

[srdjan, 2015-10-17 00:03:00]

Committed patchset #4 (id:60001) manually as
8915fb6fde71acc29ef7f3600314befaf48f17c3 (presubmit successful).