Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Issue 1409163007: [turbofan] We can inline property access for all primitives. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] We can inline property access for all primitives. TurboFan is actually able to generate property access to all prototypes of all primitives, except the special Oddball primitives that have no wrapper counterparts (namely null and undefined from the ES6 point of view). R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/eee597209b4c79a669951ea613492d69383809ec Cr-Commit-Position: refs/heads/master@{#31739}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -2 lines) Patch
M src/compiler/access-info.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/compiler/boolean-protototype.js View 1 chunk +43 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/symbol-protototype.js View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-03 08:08:25 UTC) #1
Benedikt Meurer
Hey Jaro, This generalizes the primitive property access to all primitives (except the ones for ...
5 years, 1 month ago (2015-11-03 08:09:18 UTC) #2
Michael Starzinger
LGTM.
5 years, 1 month ago (2015-11-03 10:38:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409163007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409163007/1
5 years, 1 month ago (2015-11-03 10:42:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 10:44:17 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 10:45:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eee597209b4c79a669951ea613492d69383809ec
Cr-Commit-Position: refs/heads/master@{#31739}

Powered by Google App Engine
This is Rietveld 408576698