chrome/browser/ui/views/accessibility/navigation_accessibility_uitest_win.cc - Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/accessibility/navigation_accessibility_uitest_win.cc

Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/startup/startup_browser_creator_triggered_reset_browsertest_win.cc ('k') | chrome/browser/ui/views/collected_cookies_views_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/accessibility/navigation_accessibility_uitest_win.cc

diff --git a/chrome/browser/ui/views/accessibility/navigation_accessibility_uitest_win.cc b/chrome/browser/ui/views/accessibility/navigation_accessibility_uitest_win.cc

index b9e839906c80c3c70de0df12711c07a4001413e9..71c57a385574813337b4947789bd858eefc6b640 100644

--- a/chrome/browser/ui/views/accessibility/navigation_accessibility_uitest_win.cc

+++ b/chrome/browser/ui/views/accessibility/navigation_accessibility_uitest_win.cc

@@ -22,6 +22,7 @@

#include "components/omnibox/browser/omnibox_view.h"

#include "content/public/browser/browser_accessibility_state.h"

#include "net/dns/mock_host_resolver.h"

+#include "net/test/embedded_test_server/embedded_test_server.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "ui/base/test/ui_controls.h"

#include "url/gurl.h"

@@ -208,8 +209,8 @@ IN_PROC_BROWSER_TEST_F(NavigationAccessibilityTest,

chrome::ExecuteCommand(browser(), IDC_FOCUS_LOCATION);

host_resolver()->AddRule("*", "127.0.0.1");

- ASSERT_TRUE(test_server()->Start());

- GURL main_url(test_server()->GetURL("files/english_page.html"));

+ ASSERT_TRUE(embedded_test_server()->Start());

+ GURL main_url(embedded_test_server()->GetURL("/english_page.html"));

OmniboxViewViews* omnibox_view =

BrowserView::GetBrowserViewForBrowser(browser())->