chrome/browser/ui/search_engines/search_engine_tab_helper_browsertest.cc - Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search_engines/search_engine_tab_helper_browsertest.cc

Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/search/local_ntp_browsertest.cc ('k') | chrome/browser/ui/startup/startup_browser_creator_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/search_engines/search_engine_tab_helper_browsertest.cc

diff --git a/chrome/browser/ui/search_engines/search_engine_tab_helper_browsertest.cc b/chrome/browser/ui/search_engines/search_engine_tab_helper_browsertest.cc

index 80e80329f4f26a67a3d9ce502389bd7a57adec57..4ab32fcf6d9aeb4055291f3098d9cbc74dc19316 100644

--- a/chrome/browser/ui/search_engines/search_engine_tab_helper_browsertest.cc

+++ b/chrome/browser/ui/search_engines/search_engine_tab_helper_browsertest.cc

@@ -16,7 +16,6 @@

#include "net/test/embedded_test_server/http_response.h"

using net::test_server::BasicHttpResponse;

-using net::test_server::EmbeddedTestServer;

using net::test_server::HttpRequest;

using net::test_server::HttpResponse;

@@ -89,7 +88,7 @@ class SearchEngineTabHelperBrowserTest : public InProcessBrowserTest {

embedded_test_server()->RegisterRequestHandler(

base::Bind(&SearchEngineTabHelperBrowserTest::HandleRequest,

base::Unretained(this), file_url));

- return embedded_test_server()->InitializeAndWaitUntilReady();

+ return embedded_test_server()->Start();

}

void SetUpOnMainThread() override { ASSERT_TRUE(StartTestServer()); }