chrome/browser/ui/find_bar/find_bar_host_interactive_uitest.cc - Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/find_bar/find_bar_host_interactive_uitest.cc

Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/exclusive_access/fullscreen_controller_test.cc ('k') | chrome/browser/ui/search/instant_extended_interactive_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/find_bar/find_bar_host_interactive_uitest.cc

diff --git a/chrome/browser/ui/find_bar/find_bar_host_interactive_uitest.cc b/chrome/browser/ui/find_bar/find_bar_host_interactive_uitest.cc

index 9b890cc1aceec57c370683caeb54c269e059c077..1c068d1357cce87327b4606cec80daa4f6092352 100644

--- a/chrome/browser/ui/find_bar/find_bar_host_interactive_uitest.cc

+++ b/chrome/browser/ui/find_bar/find_bar_host_interactive_uitest.cc

@@ -17,7 +17,6 @@

using base::WideToUTF16;

using content::WebContents;

-using net::test_server::EmbeddedTestServer;

namespace {

@@ -67,7 +66,7 @@ bool FocusedOnPage(WebContents* web_contents, std::string* result) {

#define MAYBE_FindInPageEndState FindInPageEndState

#endif

IN_PROC_BROWSER_TEST_F(FindInPageInteractiveTest, MAYBE_FindInPageEndState) {

- ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());

+ ASSERT_TRUE(embedded_test_server()->Start());

// Make sure Chrome is in the foreground, otherwise sending input

// won't do anything and the test will hang.