chrome/browser/task_management/providers/web_contents/tab_contents_tag_browsertest.cc - Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_management/providers/web_contents/tab_contents_tag_browsertest.cc

Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_management/providers/web_contents/subframe_task_browsertest.cc ('k') | chrome/browser/task_manager/task_manager_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_management/providers/web_contents/tab_contents_tag_browsertest.cc

diff --git a/chrome/browser/task_management/providers/web_contents/tab_contents_tag_browsertest.cc b/chrome/browser/task_management/providers/web_contents/tab_contents_tag_browsertest.cc

index 6ff3bbfa936c5adb65b63ec95f9a14302e834735..796b2a6b377b498e8c6858d7dc06886343fb0d0a 100644

--- a/chrome/browser/task_management/providers/web_contents/tab_contents_tag_browsertest.cc

+++ b/chrome/browser/task_management/providers/web_contents/tab_contents_tag_browsertest.cc

@@ -109,9 +109,7 @@ class FaviconWaiter : public favicon::FaviconDriverObserver {

// contents.

class TabContentsTagTest : public InProcessBrowserTest {

public:

- TabContentsTagTest() {

- EXPECT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());

- }

+ TabContentsTagTest() { EXPECT_TRUE(embedded_test_server()->Start()); }

~TabContentsTagTest() override {}

void AddNewTestTabAt(int index, const char* test_page_file) {