Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_test.cc

Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_test.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_test.cc b/chrome/browser/safe_browsing/safe_browsing_test.cc
index b520168c3dd444db749bf2b6e47c4be34dbbb6aa..21d992b46624141d5adcb946129caeff72de0932 100644
--- a/chrome/browser/safe_browsing/safe_browsing_test.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_test.cc
@@ -48,6 +48,7 @@
#include "net/dns/host_resolver.h"
#include "net/log/net_log.h"
#include "net/test/python_utils.h"
+#include "net/test/spawned_test_server/spawned_test_server.h"
#include "net/url_request/url_fetcher.h"
#include "net/url_request/url_fetcher_delegate.h"
#include "net/url_request/url_request_status.h"
@@ -254,7 +255,7 @@ class SafeBrowsingServerTest : public InProcessBrowserTest {
return local_database_manager()->safe_browsing_task_runner_;
}
- const net::SpawnedTestServer& test_server() const {
+ const net::SpawnedTestServer& spawned_test_server() const {
return *test_server_;
}
@@ -540,8 +541,9 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingServerTest,
}
// Fetches URLs to verify and waits till server responses with data.
- EXPECT_EQ(net::URLRequestStatus::SUCCESS,
- safe_browsing_helper->FetchUrlsToVerify(test_server(), step));
+ EXPECT_EQ(
+ net::URLRequestStatus::SUCCESS,
+ safe_browsing_helper->FetchUrlsToVerify(spawned_test_server(), step));
std::vector<PhishingUrl> phishing_urls;
EXPECT_TRUE(ParsePhishingUrls(safe_browsing_helper->response_data(),
@@ -569,15 +571,17 @@ IN_PROC_BROWSER_TEST_F(SafeBrowsingServerTest,
}
// TODO(lzheng): We should verify the fetched database with local
// database to make sure they match.
- EXPECT_EQ(net::URLRequestStatus::SUCCESS,
- safe_browsing_helper->FetchDBToVerify(test_server(), step));
+ EXPECT_EQ(
+ net::URLRequestStatus::SUCCESS,
+ safe_browsing_helper->FetchDBToVerify(spawned_test_server(), step));
EXPECT_GT(safe_browsing_helper->response_data().size(), 0U);
last_step = step;
}
// Verifies with server if test is done and waits till server responses.
EXPECT_EQ(net::URLRequestStatus::SUCCESS,
- safe_browsing_helper->VerifyTestComplete(test_server(), last_step));
+ safe_browsing_helper->VerifyTestComplete(spawned_test_server(),
+ last_step));
EXPECT_EQ("yes", safe_browsing_helper->response_data());
}

Powered by Google App Engine
This is Rietveld 408576698