Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Unified Diff: chrome/browser/extensions/window_open_apitest.cc

Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/window_open_apitest.cc
diff --git a/chrome/browser/extensions/window_open_apitest.cc b/chrome/browser/extensions/window_open_apitest.cc
index f7c02393be7cb2bd1052bd3c6a2a967e565ee61f..28d5dac150eab3ef735ddb3bd839c31a17e3ef64 100644
--- a/chrome/browser/extensions/window_open_apitest.cc
+++ b/chrome/browser/extensions/window_open_apitest.cc
@@ -194,7 +194,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_PopupBlockingExtension) {
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, PopupBlockingHostedApp) {
host_resolver()->AddRule("*", "127.0.0.1");
- ASSERT_TRUE(test_server()->Start());
+ ASSERT_TRUE(embedded_test_server()->Start());
ASSERT_TRUE(LoadExtension(
test_data_dir_.AppendASCII("window_open").AppendASCII("popup_blocking")
@@ -207,14 +207,14 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, PopupBlockingHostedApp) {
replace_host.SetHostStr("a.com");
const std::string popup_app_contents_path(
- "files/extensions/api_test/window_open/popup_blocking/hosted_app/");
-
- GURL open_tab =
- test_server()->GetURL(popup_app_contents_path + "open_tab.html")
- .ReplaceComponents(replace_host);
- GURL open_popup =
- test_server()->GetURL(popup_app_contents_path + "open_popup.html")
- .ReplaceComponents(replace_host);
+ "/extensions/api_test/window_open/popup_blocking/hosted_app/");
+
+ GURL open_tab = embedded_test_server()
+ ->GetURL(popup_app_contents_path + "open_tab.html")
+ .ReplaceComponents(replace_host);
+ GURL open_popup = embedded_test_server()
+ ->GetURL(popup_app_contents_path + "open_popup.html")
+ .ReplaceComponents(replace_host);
browser()->OpenURL(OpenURLParams(
open_tab, Referrer(), NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_TYPED,
« no previous file with comments | « chrome/browser/extensions/webstore_installer_test.cc ('k') | chrome/browser/external_extension_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698