chrome/browser/extensions/extension_loading_browsertest.cc - Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_loading_browsertest.cc

Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_keybinding_apitest.cc ('k') | chrome/browser/extensions/extension_messages_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_loading_browsertest.cc

diff --git a/chrome/browser/extensions/extension_loading_browsertest.cc b/chrome/browser/extensions/extension_loading_browsertest.cc

index b828879b99421277390e01f0b1c6f7dfedb2788c..4e82ad16a77405a3901f0c547cc30985eea0b848 100644

--- a/chrome/browser/extensions/extension_loading_browsertest.cc

+++ b/chrome/browser/extensions/extension_loading_browsertest.cc

@@ -33,7 +33,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionLoadingTest,

UpgradeAfterNavigatingFromOverriddenNewTabPage) {

embedded_test_server()->ServeFilesFromDirectory(

base::FilePath(FILE_PATH_LITERAL("chrome/test/data")));

- ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());

+ ASSERT_TRUE(embedded_test_server()->Start());

TestExtensionDir extension_dir;

const char manifest_template[] =

@@ -99,7 +99,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionLoadingTest,

KeepAliveWithDevToolsOpenOnReload) {

embedded_test_server()->ServeFilesFromDirectory(

base::FilePath(FILE_PATH_LITERAL("chrome/test/data")));

- ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());

+ ASSERT_TRUE(embedded_test_server()->Start());

TestExtensionDir extension_dir;

const char manifest_contents[] =