chrome/browser/extensions/api/context_menus/context_menu_apitest.cc - Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/context_menus/context_menu_apitest.cc

Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc ('k') | chrome/browser/extensions/api/declarative_content/request_content_script_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/context_menus/context_menu_apitest.cc

diff --git a/chrome/browser/extensions/api/context_menus/context_menu_apitest.cc b/chrome/browser/extensions/api/context_menus/context_menu_apitest.cc

index e4cd9cff4b9d5e66573ab6bc2f28a921b779eca3..2dcdab1370992e380e77e15e2b375809aedcdbba 100644

--- a/chrome/browser/extensions/api/context_menus/context_menu_apitest.cc

+++ b/chrome/browser/extensions/api/context_menus/context_menu_apitest.cc

@@ -9,6 +9,7 @@

#include "chrome/browser/ui/browser.h"

#include "chrome/test/base/ui_test_utils.h"

#include "extensions/test/result_catcher.h"

+#include "net/test/embedded_test_server/embedded_test_server.h"

namespace extensions {

@@ -28,7 +29,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_ContextMenus) {

// crbug.com/51436 -- creating context menus from multiple script contexts

// should work.

IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ContextMenusFromMultipleContexts) {

- ASSERT_TRUE(test_server()->Start());

+ ASSERT_TRUE(embedded_test_server()->Start());

ASSERT_TRUE(RunExtensionTest("context_menus/add_from_multiple_contexts"))

<< message_;

const extensions::Extension* extension = GetSingleLoadedExtension();