chrome/browser/chrome_service_worker_browsertest.cc - Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_service_worker_browsertest.cc

Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_security_exploit_browsertest.cc ('k') | chrome/browser/chrome_site_per_process_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_service_worker_browsertest.cc

diff --git a/chrome/browser/chrome_service_worker_browsertest.cc b/chrome/browser/chrome_service_worker_browsertest.cc

index 3a2042085e20dcc91310673aeec4c55d148bf720..e6c32fd7a9a2760c577ad2e2341dfcdf2a86cb13 100644

--- a/chrome/browser/chrome_service_worker_browsertest.cc

+++ b/chrome/browser/chrome_service_worker_browsertest.cc

@@ -56,7 +56,7 @@ IN_PROC_BROWSER_TEST_F(ChromeServiceWorkerTest,

"HTTP/1.1 200 OK\nContent-Type: text/javascript");

embedded_test_server()->ServeFilesFromDirectory(service_worker_dir_.path());

- ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());

+ ASSERT_TRUE(embedded_test_server()->Start());

content::ServiceWorkerContext* sw_context =

content::BrowserContext::GetDefaultStoragePartition(browser()->profile())

@@ -84,7 +84,7 @@ IN_PROC_BROWSER_TEST_F(ChromeServiceWorkerTest,

WriteFile(FILE_PATH_LITERAL("test.html"), "");

embedded_test_server()->ServeFilesFromDirectory(service_worker_dir_.path());

- ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());

+ ASSERT_TRUE(embedded_test_server()->Start());

Browser* incognito = CreateIncognitoBrowser();

content::ServiceWorkerContext* sw_context =

« no previous file with comments | « chrome/browser/chrome_security_exploit_browsertest.cc ('k') | chrome/browser/chrome_site_per_process_browsertest.cc » ('j') | no next file with comments »