Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3260)

Unified Diff: chrome/browser/ui/webui/downloads_dom_handler_browsertest.cc

Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix rebase bug. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/downloads_dom_handler_browsertest.cc
diff --git a/chrome/browser/ui/webui/downloads_dom_handler_browsertest.cc b/chrome/browser/ui/webui/downloads_dom_handler_browsertest.cc
index 7c8dcf54b2f96ce9923fb2eba0edd6fb22491f77..1e0b1f1d55b3efd83fb89c159f9b71be7753138c 100644
--- a/chrome/browser/ui/webui/downloads_dom_handler_browsertest.cc
+++ b/chrome/browser/ui/webui/downloads_dom_handler_browsertest.cc
@@ -17,6 +17,7 @@
#include "content/public/test/mock_download_item.h"
#include "content/public/test/mock_download_manager.h"
#include "content/public/test/test_utils.h"
+#include "net/test/embedded_test_server/embedded_test_server.h"
namespace {
@@ -129,7 +130,7 @@ class DownloadsDOMHandlerTest : public InProcessBrowserTest {
browser()->profile()->GetPrefs()->SetFilePath(
prefs::kDownloadDefaultDirectory,
downloads_directory_.path());
- CHECK(test_server()->Start());
+ CHECK(embedded_test_server()->Start());
mock_handler_->HandleGetDownloads(nullptr);
}
@@ -138,7 +139,7 @@ class DownloadsDOMHandlerTest : public InProcessBrowserTest {
}
void DownloadAnItem() {
- GURL url = test_server()->GetURL("files/downloads/image.jpg");
+ GURL url = embedded_test_server()->GetURL("/downloads/image.jpg");
std::vector<GURL> url_chain;
url_chain.push_back(url);
base::Time current(base::Time::Now());

Powered by Google App Engine
This is Rietveld 408576698