chrome/browser/banners/app_banner_data_fetcher_browsertest.cc - Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/banners/app_banner_data_fetcher_browsertest.cc

Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix rebase bug. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autofill/autofill_interactive_uitest.cc ('k') | chrome/browser/browser_keyevents_browsertest.cc » ('j') | chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/banners/app_banner_data_fetcher_browsertest.cc

diff --git a/chrome/browser/banners/app_banner_data_fetcher_browsertest.cc b/chrome/browser/banners/app_banner_data_fetcher_browsertest.cc

index e803089b2354bf95f4aed2813877f1e4e46c3e50..b37df5fc13e3708897afd3fc00a7aa7d1c354357 100644

--- a/chrome/browser/banners/app_banner_data_fetcher_browsertest.cc

+++ b/chrome/browser/banners/app_banner_data_fetcher_browsertest.cc

@@ -65,7 +65,7 @@ class AppBannerDataFetcherBrowserTest : public InProcessBrowserTest,

void SetUpOnMainThread() override {

AppBannerSettingsHelper::SetEngagementWeights(1, 1);

AppBannerSettingsHelper::SetTotalEngagementToTrigger(2);

- ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());

+ ASSERT_TRUE(embedded_test_server()->Start());

InProcessBrowserTest::SetUpOnMainThread();

}