Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Side by Side Diff: chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc

Issue 1409163006: Migrating tests to use EmbeddedTestServer (/chrome/browser misc) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/cloud_print_private/cloud_print_private_ api.h" 5 #include "chrome/browser/extensions/api/cloud_print_private/cloud_print_private_ api.h"
6 6
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "chrome/browser/extensions/extension_apitest.h" 8 #include "chrome/browser/extensions/extension_apitest.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
11 #include "chrome/common/extensions/api/cloud_print_private.h" 11 #include "chrome/common/extensions/api/cloud_print_private.h"
12 #include "components/cloud_devices/common/cloud_devices_switches.h" 12 #include "components/cloud_devices/common/cloud_devices_switches.h"
13 #include "net/dns/mock_host_resolver.h" 13 #include "net/dns/mock_host_resolver.h"
14 #include "net/test/embedded_test_server/embedded_test_server.h"
14 #include "testing/gmock/include/gmock/gmock.h" 15 #include "testing/gmock/include/gmock/gmock.h"
15 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
16 17
17 using ::testing::Eq; 18 using ::testing::Eq;
18 using ::testing::Property; 19 using ::testing::Property;
19 using ::testing::Return; 20 using ::testing::Return;
20 using ::testing::_; 21 using ::testing::_;
21 22
22 // A base class for tests below. 23 // A base class for tests below.
23 class ExtensionCloudPrintPrivateApiTest : public ExtensionApiTest { 24 class ExtensionCloudPrintPrivateApiTest : public ExtensionApiTest {
24 public: 25 public:
25 void SetUpCommandLine(base::CommandLine* command_line) override { 26 void SetUpCommandLine(base::CommandLine* command_line) override {
26 ExtensionApiTest::SetUpCommandLine(command_line); 27 ExtensionApiTest::SetUpCommandLine(command_line);
27 command_line->AppendSwitchASCII( 28 command_line->AppendSwitchASCII(
28 switches::kCloudPrintURL, 29 switches::kCloudPrintURL,
29 "http://www.cloudprintapp.com/files/extensions/api_test/" 30 "http://www.cloudprintapp.com/extensions/api_test/"
30 "cloud_print_private"); 31 "cloud_print_private");
31 } 32 }
32 33
33 void SetUpInProcessBrowserTestFixture() override { 34 void SetUpInProcessBrowserTestFixture() override {
34 // Start up the test server and get us ready for calling the install 35 // Start up the test server and get us ready for calling the install
35 // API functions. 36 // API functions.
36 host_resolver()->AddRule("www.cloudprintapp.com", "127.0.0.1"); 37 host_resolver()->AddRule("www.cloudprintapp.com", "127.0.0.1");
37 ASSERT_TRUE(test_server()->Start()); 38 ASSERT_TRUE(embedded_test_server()->Start());
38 } 39 }
39 40
40 protected: 41 protected:
41 // Returns a test server URL, but with host 'www.cloudprintapp.com' so it 42 // Returns a test server URL, but with host 'www.cloudprintapp.com' so it
42 // matches the cloud print app's extent that we set up via command line 43 // matches the cloud print app's extent that we set up via command line
43 // flags. 44 // flags.
44 GURL GetTestServerURL(const std::string& path) { 45 GURL GetTestServerURL(const std::string& path) {
45 GURL url = test_server()->GetURL( 46 GURL url = embedded_test_server()->GetURL(
46 "files/extensions/api_test/cloud_print_private/" + path); 47 "/extensions/api_test/cloud_print_private/" + path);
47 48
48 // Replace the host with 'www.cloudprintapp.com' so it matches the cloud 49 // Replace the host with 'www.cloudprintapp.com' so it matches the cloud
49 // print app's extent. 50 // print app's extent.
50 GURL::Replacements replace_host; 51 GURL::Replacements replace_host;
51 replace_host.SetHostStr("www.cloudprintapp.com"); 52 replace_host.SetHostStr("www.cloudprintapp.com");
52 return url.ReplaceComponents(replace_host); 53 return url.ReplaceComponents(replace_host);
53 } 54 }
54 }; 55 };
55 56
56 #if !defined(OS_CHROMEOS) 57 #if !defined(OS_CHROMEOS)
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 114
114 // Run this as a hosted app. Since we have overridden the cloud print service 115 // Run this as a hosted app. Since we have overridden the cloud print service
115 // URL in the command line, this URL should match the web extent for our 116 // URL in the command line, this URL should match the web extent for our
116 // cloud print component app and it should work. 117 // cloud print component app and it should work.
117 GURL page_url = GetTestServerURL( 118 GURL page_url = GetTestServerURL(
118 "enable_chrome_connector/cloud_print_success_tests.html"); 119 "enable_chrome_connector/cloud_print_success_tests.html");
119 ASSERT_TRUE(RunPageTest(page_url.spec())); 120 ASSERT_TRUE(RunPageTest(page_url.spec()));
120 } 121 }
121 122
122 #endif // !defined(OS_CHROMEOS) 123 #endif // !defined(OS_CHROMEOS)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698