Migrating tests to use EmbeddedTestServer (/chrome/browser misc)

chrome/browser/extensions/extension_keybinding_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/extensions/active_tab_permission_granter.h"
 #include "chrome/browser/extensions/api/commands/command_service.h"
 #include "chrome/browser/extensions/browser_action_test_util.h"
 #include "chrome/browser/extensions/component_loader.h"
@@ skipping 11 matching lines @@
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/test/javascript_test_observer.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/feature_switch.h"
 #include "extensions/common/manifest_constants.h"
 #include "extensions/common/permissions/permissions_data.h"
 #include "extensions/test/extension_test_message_listener.h"
 #include "extensions/test/result_catcher.h"
+#include "net/test/embedded_test_server/embedded_test_server.h"
 
 using content::WebContents;
 
 namespace extensions {
 
 namespace {
 
 // This extension ID is used for tests require a stable ID over multiple
 // extension installs.
 const char kId[] = "pgoakhfeplldmjheffidklpoklkppipp";
@@ skipping 93 matching lines @@
  protected:
   bool IsGrantedForTab(const Extension* extension,
                        const content::WebContents* web_contents) {
     return extension->permissions_data()->HasAPIPermissionForTab(
         SessionTabHelper::IdForTab(web_contents), APIPermission::kTab);
   }
 
 #if defined(OS_CHROMEOS)
   void RunChromeOSConversionTest(const std::string& extension_path) {
     // Setup the environment.
-    ASSERT_TRUE(test_server()->Start());
+    ASSERT_TRUE(embedded_test_server()->Start());
     ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
     ASSERT_TRUE(RunExtensionTest(extension_path)) << message_;
     ui_test_utils::NavigateToURL(
-        browser(), test_server()->GetURL("files/extensions/test_file.txt"));
+        browser(), embedded_test_server()->GetURL("/extensions/test_file.txt"));
 
     ResultCatcher catcher;
 
     // Send all expected keys (Search+Shift+{Left, Up, Right, Down}).
     ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
         browser(), ui::VKEY_LEFT, false, true, false, true));
     ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
         browser(), ui::VKEY_UP, false, true, false, true));
     ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
         browser(), ui::VKEY_RIGHT, false, true, false, true));
     ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
         browser(), ui::VKEY_DOWN, false, true, false, true));
 
     ASSERT_TRUE(catcher.GetNextResult());
   }
 #endif  // OS_CHROMEOS
 };
 
 // Test the basic functionality of the Keybinding API:
 // - That pressing the shortcut keys should perform actions (activate the
 //   browser action or send an event).
 // - Note: Page action keybindings are tested in PageAction test below.
 // - The shortcut keys taken by one extension are not overwritten by the last
 //   installed extension.
 IN_PROC_BROWSER_TEST_F(CommandsApiTest, Basic) {
-  ASSERT_TRUE(test_server()->Start());
+  ASSERT_TRUE(embedded_test_server()->Start());
   ASSERT_TRUE(RunExtensionTest("keybinding/basics")) << message_;
   const Extension* extension = GetSingleLoadedExtension();
   ASSERT_TRUE(extension) << message_;
 
   // Load this extension, which uses the same keybindings but sets the page
   // to different colors. This is so we can see that it doesn't interfere. We
   // don't test this extension in any other way (it should otherwise be
   // immaterial to this test).
   ASSERT_TRUE(RunExtensionTest("keybinding/conflicting")) << message_;
 
   BrowserActionTestUtil browser_actions_bar(browser());
   // Test that there are two browser actions in the toolbar.
   ASSERT_EQ(2, browser_actions_bar.NumberOfBrowserActions());
 
   ui_test_utils::NavigateToURL(
-      browser(), test_server()->GetURL("files/extensions/test_file.txt"));
+      browser(), embedded_test_server()->GetURL("/extensions/test_file.txt"));
 
   // activeTab shouldn't have been granted yet.
   WebContents* tab = browser()->tab_strip_model()->GetActiveWebContents();
   ASSERT_TRUE(tab);
 
   EXPECT_FALSE(IsGrantedForTab(extension, tab));
 
   ExtensionTestMessageListener test_listener(false);  // Won't reply.
   // Activate the browser action shortcut (Ctrl+Shift+F).
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
       browser(), ui::VKEY_F, true, true, false, false));
   EXPECT_TRUE(test_listener.WaitUntilSatisfied());
   // activeTab should now be granted.
   EXPECT_TRUE(IsGrantedForTab(extension, tab));
   // Verify the command worked.
   EXPECT_EQ(std::string("basics browser action"), test_listener.message());
 
   test_listener.Reset();
   // Activate the command shortcut (Ctrl+Shift+Y).
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
       browser(), ui::VKEY_Y, true, true, false, false));
   EXPECT_TRUE(test_listener.WaitUntilSatisfied());
   EXPECT_EQ(std::string(kBasicsShortcutCommandName), test_listener.message());
 }
 
 IN_PROC_BROWSER_TEST_F(CommandsApiTest, PageAction) {
-  ASSERT_TRUE(test_server()->Start());
+  ASSERT_TRUE(embedded_test_server()->Start());
   ASSERT_TRUE(RunExtensionTest("keybinding/page_action")) << message_;
   const Extension* extension = GetSingleLoadedExtension();
   ASSERT_TRUE(extension) << message_;
 
   {
     // Load a page, the extension will detect the navigation and request to show
     // the page action icon.
     ResultCatcher catcher;
     ui_test_utils::NavigateToURL(
-        browser(), test_server()->GetURL("files/extensions/test_file.txt"));
+        browser(), embedded_test_server()->GetURL("/extensions/test_file.txt"));
     ASSERT_TRUE(catcher.GetNextResult());
   }
 
   // Make sure it appears and is the right one.
   ASSERT_TRUE(WaitForPageActionVisibilityChangeTo(1));
   int tab_id = SessionTabHelper::FromWebContents(
       browser()->tab_strip_model()->GetActiveWebContents())->session_id().id();
   ExtensionAction* action =
       ExtensionActionManager::Get(browser()->profile())->
       GetPageAction(*extension);
   ASSERT_TRUE(action);
   EXPECT_EQ("Send message", action->GetTitle(tab_id));
 
   ExtensionTestMessageListener test_listener(false);  // Won't reply.
   test_listener.set_extension_id(extension->id());
 
   // Activate the shortcut (Alt+Shift+F).
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
       browser(), ui::VKEY_F, false, true, true, false));
 
   test_listener.WaitUntilSatisfied();
   EXPECT_EQ("clicked", test_listener.message());
 }
 
 IN_PROC_BROWSER_TEST_F(CommandsApiTest, PageActionKeyUpdated) {
-  ASSERT_TRUE(test_server()->Start());
+  ASSERT_TRUE(embedded_test_server()->Start());
   ASSERT_TRUE(RunExtensionTest("keybinding/page_action")) << message_;
   const Extension* extension = GetSingleLoadedExtension();
   ASSERT_TRUE(extension) << message_;
 
   CommandService* command_service = CommandService::Get(browser()->profile());
   // Simulate the user setting the keybinding to Alt+Shift+G.
   command_service->UpdateKeybindingPrefs(
       extension->id(), manifest_values::kPageActionCommandEvent, kAltShiftG);
 
   {
     // Load a page. The extension will detect the navigation and request to show
     // the page action icon.
     ResultCatcher catcher;
     ui_test_utils::NavigateToURL(
-        browser(), test_server()->GetURL("files/extensions/test_file.txt"));
+        browser(), embedded_test_server()->GetURL("/extensions/test_file.txt"));
     ASSERT_TRUE(catcher.GetNextResult());
   }
 
   ExtensionTestMessageListener test_listener(false);  // Won't reply.
   test_listener.set_extension_id(extension->id());
 
   // Activate the shortcut.
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
       browser(), ui::VKEY_G, false, true, true, false));
 
   test_listener.WaitUntilSatisfied();
   EXPECT_EQ("clicked", test_listener.message());
 }
 
 // This test validates that the getAll query API function returns registered
 // commands as well as synthesized ones and that inactive commands (like the
 // synthesized ones are in nature) have no shortcuts.
 IN_PROC_BROWSER_TEST_F(CommandsApiTest, SynthesizedCommand) {
-  ASSERT_TRUE(test_server()->Start());
+  ASSERT_TRUE(embedded_test_server()->Start());
   ASSERT_TRUE(RunExtensionTest("keybinding/synthesized")) << message_;
 }
 
 // This test validates that an extension cannot request a shortcut that is
 // already in use by Chrome.
 IN_PROC_BROWSER_TEST_F(CommandsApiTest, DontOverwriteSystemShortcuts) {
-  ASSERT_TRUE(test_server()->Start());
+  ASSERT_TRUE(embedded_test_server()->Start());
 
   ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
 
   ASSERT_TRUE(RunExtensionTest("keybinding/dont_overwrite_system")) << message_;
 
   ui_test_utils::NavigateToURL(
-      browser(), test_server()->GetURL("files/extensions/test_file.txt"));
+      browser(), embedded_test_server()->GetURL("/extensions/test_file.txt"));
 
   // Activate the regular shortcut (Alt+Shift+F).
   ExtensionTestMessageListener alt_shift_f_listener("alt_shift_f", false);
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
       browser(), ui::VKEY_F, false, true, true, false));
   EXPECT_TRUE(alt_shift_f_listener.WaitUntilSatisfied());
 
   // Try to activate the bookmark shortcut (Ctrl+D). This should not work
   // without requesting via chrome_settings_overrides.
   //
@@ skipping 25 matching lines @@
     ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
         browser(), ui::VKEY_F, false, true, true, false));
     EXPECT_TRUE(alt_shift_f_listener.WaitUntilSatisfied());
     EXPECT_FALSE(ctrl_f_listener.was_satisfied());
   }
 }
 
 // This test validates that an extension can remove the Chrome bookmark shortcut
 // if it has requested to do so.
 IN_PROC_BROWSER_TEST_F(CommandsApiTest, RemoveBookmarkShortcut) {
-  ASSERT_TRUE(test_server()->Start());
+  ASSERT_TRUE(embedded_test_server()->Start());
 
   ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
 
   // This functionality requires a feature flag.
   base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
       "--enable-override-bookmarks-ui", "1");
 
   ASSERT_TRUE(RunExtensionTest("keybinding/remove_bookmark_shortcut"))
       << message_;
 
   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_BOOKMARK_PAGE));
 }
 
 // This test validates that an extension cannot remove the Chrome bookmark
 // shortcut without being given permission with a feature flag.
 IN_PROC_BROWSER_TEST_F(CommandsApiTest,
                        RemoveBookmarkShortcutWithoutPermission) {
-  ASSERT_TRUE(test_server()->Start());
+  ASSERT_TRUE(embedded_test_server()->Start());
 
   ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
 
   EXPECT_TRUE(RunExtensionTestIgnoreManifestWarnings(
       "keybinding/remove_bookmark_shortcut"));
 
   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_BOOKMARK_PAGE));
 }
 
 // This test validates that an extension that removes the Chrome bookmark
 // shortcut continues to remove the bookmark shortcut with a user-assigned
 // Ctrl+D shortcut (i.e. it does not trigger the overwrite functionality).
 IN_PROC_BROWSER_TEST_F(CommandsApiTest,
                        RemoveBookmarkShortcutWithUserKeyBinding) {
-  ASSERT_TRUE(test_server()->Start());
+  ASSERT_TRUE(embedded_test_server()->Start());
 
   ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
 
   // This functionality requires a feature flag.
   base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
       "--enable-override-bookmarks-ui", "1");
 
   ASSERT_TRUE(RunExtensionTest("keybinding/remove_bookmark_shortcut"))
       << message_;
 
   // Check that the shortcut is removed.
   CommandService* command_service = CommandService::Get(browser()->profile());
   const Extension* extension = GetSingleLoadedExtension();
   // Simulate the user setting a keybinding to Ctrl+D.
   command_service->UpdateKeybindingPrefs(
       extension->id(), manifest_values::kBrowserActionCommandEvent,
       kBookmarkKeybinding);
 
   // Force the command enable state to be recalculated.
   browser()->command_controller()->ExtensionStateChanged();
 
   EXPECT_FALSE(chrome::IsCommandEnabled(browser(), IDC_BOOKMARK_PAGE));
 }
 
 // This test validates that an extension can override the Chrome bookmark
 // shortcut if it has requested to do so.
 IN_PROC_BROWSER_TEST_F(CommandsApiTest, OverwriteBookmarkShortcut) {
-  ASSERT_TRUE(test_server()->Start());
+  ASSERT_TRUE(embedded_test_server()->Start());
 
   ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
 
   // This functionality requires a feature flag.
   base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
       "--enable-override-bookmarks-ui", "1");
 
   ASSERT_TRUE(RunExtensionTest("keybinding/overwrite_bookmark_shortcut"))
       << message_;
 
   ui_test_utils::NavigateToURL(
-      browser(), test_server()->GetURL("files/extensions/test_file.txt"));
+      browser(), embedded_test_server()->GetURL("/extensions/test_file.txt"));
 
   // Activate the shortcut (Ctrl+D) to send a test message.
   ExtensionTestMessageListener test_listener(false);  // Won't reply.
   ASSERT_TRUE(SendBookmarkKeyPressSync(browser()));
   EXPECT_TRUE(test_listener.WaitUntilSatisfied());
   EXPECT_EQ(std::string(kOverwriteBookmarkShortcutCommandName),
             test_listener.message());
 }
 
 // This test validates that an extension that requests to override the Chrome
 // bookmark shortcut, but does not get the keybinding, does not remove the
 // bookmark UI.
 IN_PROC_BROWSER_TEST_F(CommandsApiTest,
                        OverwriteBookmarkShortcutWithoutKeybinding) {
   // This functionality requires a feature flag.
   base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
       "--enable-override-bookmarks-ui", "1");
 
-  ASSERT_TRUE(test_server()->Start());
+  ASSERT_TRUE(embedded_test_server()->Start());
 
   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_BOOKMARK_PAGE));
 
   ASSERT_TRUE(RunExtensionTest("keybinding/overwrite_bookmark_shortcut"))
       << message_;
 
   const Extension* extension = GetSingleLoadedExtension();
   CommandService* command_service = CommandService::Get(browser()->profile());
   CommandMap commands;
   // Verify the expected command is present.
   EXPECT_TRUE(command_service->GetNamedCommands(
       extension->id(), CommandService::SUGGESTED, CommandService::ANY_SCOPE,
       &commands));
   EXPECT_EQ(1u, commands.count(kOverwriteBookmarkShortcutCommandName));
 
   // Simulate the user removing the Ctrl+D keybinding from the command.
   command_service->RemoveKeybindingPrefs(
       extension->id(), kOverwriteBookmarkShortcutCommandName);
 
   // Force the command enable state to be recalculated.
   browser()->command_controller()->ExtensionStateChanged();
 
   EXPECT_TRUE(chrome::IsCommandEnabled(browser(), IDC_BOOKMARK_PAGE));
 }
 
 // This test validates that an extension override of the Chrome bookmark
 // shortcut does not supersede the same keybinding by web pages.
 IN_PROC_BROWSER_TEST_F(CommandsApiTest,
                        OverwriteBookmarkShortcutDoesNotOverrideWebKeybinding) {
-  ASSERT_TRUE(test_server()->Start());
+  ASSERT_TRUE(embedded_test_server()->Start());
 
   ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
 
   // This functionality requires a feature flag.
   base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
       "--enable-override-bookmarks-ui", "1");
 
   ASSERT_TRUE(RunExtensionTest("keybinding/overwrite_bookmark_shortcut"))
       << message_;
 
   ui_test_utils::NavigateToURL(
-      browser(),
-      test_server()->GetURL(
-          "files/extensions/test_file_with_ctrl-d_keybinding.html"));
+      browser(), embedded_test_server()->GetURL(
+                     "/extensions/test_file_with_ctrl-d_keybinding.html"));
 
   WebContents* tab = browser()->tab_strip_model()->GetActiveWebContents();
   ASSERT_TRUE(tab);
 
   // Activate the shortcut (Ctrl+D) which should be handled by the page and send
   // a test message.
   DomMessageListener listener(tab);
   ASSERT_TRUE(SendBookmarkKeyPressSync(browser()));
   listener.Wait();
   EXPECT_EQ(std::string("\"web page received\""), listener.message());
 }
 
 // This test validates that user-set override of the Chrome bookmark shortcut in
 // an extension that does not request it does supersede the same keybinding by
 // web pages.
 IN_PROC_BROWSER_TEST_F(CommandsApiTest,
                        OverwriteBookmarkShortcutByUserOverridesWebKeybinding) {
-  ASSERT_TRUE(test_server()->Start());
+  ASSERT_TRUE(embedded_test_server()->Start());
 
   ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
 
   // This functionality requires a feature flag.
   base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
       "--enable-override-bookmarks-ui", "1");
 
   ASSERT_TRUE(RunExtensionTest("keybinding/basics"))
       << message_;
 
   CommandService* command_service = CommandService::Get(browser()->profile());
 
   const Extension* extension = GetSingleLoadedExtension();
   // Simulate the user setting the keybinding to Ctrl+D.
   command_service->UpdateKeybindingPrefs(
       extension->id(), manifest_values::kBrowserActionCommandEvent,
       kBookmarkKeybinding);
 
   ui_test_utils::NavigateToURL(
-      browser(),
-      test_server()->GetURL(
-          "files/extensions/test_file_with_ctrl-d_keybinding.html"));
+      browser(), embedded_test_server()->GetURL(
+                     "/extensions/test_file_with_ctrl-d_keybinding.html"));
 
   ExtensionTestMessageListener test_listener(false);  // Won't reply.
   // Activate the shortcut (Ctrl+D) which should be handled by the extension.
   ASSERT_TRUE(SendBookmarkKeyPressSync(browser()));
   EXPECT_TRUE(test_listener.WaitUntilSatisfied());
   EXPECT_EQ(std::string("basics browser action"), test_listener.message());
 }
 
 #if defined(OS_WIN)
 // Currently this feature is implemented on Windows only.
@@ skipping 372 matching lines @@
 //
 #if defined(OS_CHROMEOS) && !defined(NDEBUG)
 // TODO(dtseng): Test times out on Chrome OS debug. See http://crbug.com/412456.
 #define MAYBE_ContinuePropagation DISABLED_ContinuePropagation
 #else
 #define MAYBE_ContinuePropagation ContinuePropagation
 #endif
 
 IN_PROC_BROWSER_TEST_F(CommandsApiTest, MAYBE_ContinuePropagation) {
   // Setup the environment.
-  ASSERT_TRUE(test_server()->Start());
+  ASSERT_TRUE(embedded_test_server()->Start());
   ASSERT_TRUE(ui_test_utils::BringBrowserWindowToFront(browser()));
   ASSERT_TRUE(RunExtensionTest("keybinding/continue_propagation")) << message_;
   ui_test_utils::NavigateToURL(
-      browser(), test_server()->GetURL("files/extensions/test_file.txt"));
+      browser(), embedded_test_server()->GetURL("/extensions/test_file.txt"));
 
   ResultCatcher catcher;
 
   // Activate the shortcut (Ctrl+Shift+F). The page should capture the
   // keystroke and not the extension since |onCommand| has no event listener
   // initially.
   ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
       browser(), ui::VKEY_F, true, true, false, false));
   ASSERT_TRUE(catcher.GetNextResult());
 
@@ skipping 19 matching lines @@
 #define MAYBE_ChromeOSConversions ChromeOSConversions
 #endif
 IN_PROC_BROWSER_TEST_F(CommandsApiTest, MAYBE_ChromeOSConversions) {
   RunChromeOSConversionTest("keybinding/chromeos_conversions");
 }
 #endif  // OS_CHROMEOS
 
 // Make sure component extensions retain keybindings after removal then
 // re-adding.
 IN_PROC_BROWSER_TEST_F(CommandsApiTest, AddRemoveAddComponentExtension) {
-  ASSERT_TRUE(test_server()->Start());
+  ASSERT_TRUE(embedded_test_server()->Start());
   ASSERT_TRUE(RunComponentExtensionTest("keybinding/component")) << message_;
 
   extensions::ExtensionSystem::Get(browser()->profile())
       ->extension_service()
       ->component_loader()
       ->Remove("pkplfbidichfdicaijlchgnapepdginl");
 
   ASSERT_TRUE(RunComponentExtensionTest("keybinding/component")) << message_;
 }
 
 }  // namespace extensions