Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 1409153008: Revert of [turbofan] Enable general purpose inlining. (Closed)

Created:
5 years, 1 month ago by Michael Hablich
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Enable general purpose inlining. (patchset #2 id:20001 of https://codereview.chromium.org/1416873007/ ) Reason for revert: As discussed with Benedikt: Disable --turbo-inlining again because it tanks Jetstream. Original issue's description: > [turbofan] Enable general purpose inlining. > > R=bmeurer@chromium.org,hablich@chromium.org > BUG=v8:4493 > LOG=n > > Committed: https://crrev.com/161a0462fb0e79f155f3ea085ba774dad99539cb > Cr-Commit-Position: refs/heads/master@{#31634} TBR=bmeurer@chromium.org,mstarzinger@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4493 Committed: https://crrev.com/17a4e20e0d28bb50ed8605e1fe5ff849c8765021 Cr-Commit-Position: refs/heads/master@{#31855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Hablich
Created Revert of [turbofan] Enable general purpose inlining.
5 years, 1 month ago (2015-11-06 13:07:41 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
5 years, 1 month ago (2015-11-06 13:08:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1409153008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1409153008/1
5 years, 1 month ago (2015-11-06 13:09:20 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 13:09:30 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 13:09:57 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17a4e20e0d28bb50ed8605e1fe5ff849c8765021
Cr-Commit-Position: refs/heads/master@{#31855}

Powered by Google App Engine
This is Rietveld 408576698