Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1409153007: Merge to XFA: Make checkdeps --resolve-dotdot succeed. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Make checkdeps --resolve-dotdot succeed. This is just a straight-forward, partial merge. It does not actually make checkdeps succeed. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1419373005 . (cherry picked from commit 79f5a32175293620abe456554e10efb7c3f4e7c6) Committed: https://pdfium.googlesource.com/pdfium/+/8fec3e42ed57a988ad5e7faae5e6a83847a3267e

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -18 lines) Patch
M DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
M core/include/fpdfapi/fpdf_render.h View 2 chunks +7 lines, -6 lines 0 comments Download
A core/include/fxcodec/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_embeddertest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M fpdfsdk/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_progressive.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
A public/DEPS View 1 chunk +8 lines, -0 lines 0 comments Download
M samples/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M testing/DEPS View 1 chunk +1 line, -1 line 0 comments Download
A third_party/DEPS View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/agg23/agg_rasterizer_scanline_aa.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/agg23/agg_rasterizer_scanline_aa.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Lei Zhang
The files I did not merge are: core/include/fpdfapi/fpdf_parser.h core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp fpdfsdk/src/fpdf_dataavail.cpp public/fpdf_dataavail.h Because public/fpdf_dataavail.h is different ...
5 years, 1 month ago (2015-11-04 22:37:39 UTC) #1
Lei Zhang
And updated CL description due to false advertising.
5 years, 1 month ago (2015-11-04 22:39:34 UTC) #3
Tom Sepez
lgtm
5 years, 1 month ago (2015-11-04 23:05:14 UTC) #4
Lei Zhang
5 years, 1 month ago (2015-11-04 23:32:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8fec3e42ed57a988ad5e7faae5e6a83847a3267e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698